From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23805 invoked by alias); 28 Apr 2002 00:25:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23796 invoked from network); 28 Apr 2002 00:25:12 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 28 Apr 2002 00:25:12 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 171cVJ-0002MC-00; Sat, 27 Apr 2002 20:25:25 -0400 Date: Sat, 27 Apr 2002 17:25:00 -0000 From: Daniel Jacobowitz To: Andreas Schwab Cc: gdb-patches@sources.redhat.com Subject: Re: S390[x] configuration update Message-ID: <20020427202525.A8877@nevyn.them.org> Mail-Followup-To: Andreas Schwab , gdb-patches@sources.redhat.com References: <20020427192408.A6259@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg01107.txt.bz2 On Sun, Apr 28, 2002 at 02:13:34AM +0200, Andreas Schwab wrote: > Daniel Jacobowitz writes: > > |> On Sun, Apr 28, 2002 at 12:41:03AM +0200, Andreas Schwab wrote: > |> > This updates the S390/S390x configuration to follow the latest wisdom. > |> > > |> > 2002-04-28 Andreas Schwab > |> > > |> > * config/s390/s390.mh (NATDEPFILES): Remove slib.o and > |> > core-regset.o, add linux-proc.o and gcore.o. > |> > |> Er.... what? Why remove solib.o and core-regset.o? > > solib.o is in TDEPFILES, the same as all other linux targets. But > removing core-regset.o was wrong. Misunderstanding from my side, sorry. Oh, right. I forgot that it had moved. > |> Also, I bet you didn't build test this. > > Of course, I did. But I forgot to test corefile functionality. > > Btw, config/i386/linux.mh NATDEPFILES lists linux-proc.o twice. I wonder why I thought that... I was assuming you hadn't added linux-proc.o, which you obviously did. Sorry. The updated patch looks good to me; you can probably just commit it, since it fixes a build failure and is quite straightforward. > 2002-04-28 Andreas Schwab > > * config/s390/s390.mh (NATDEPFILES): Remove slib.o, add > linux-proc.o and gcore.o. "solib.o" > > --- gdb/config/s390/s390.mh 2002/04/27 18:51:58 1.1 > +++ gdb/config/s390/s390.mh 2002/04/27 23:42:01 > @@ -4,9 +4,9 @@ XM_FILE= xm-linux.h > XM_CLIBS= > > NAT_FILE= nm-linux.h > -NATDEPFILES= infptrace.o solib.o inftarg.o fork-child.o corelow.o s390-nat.o core-aout.o core-regset.o > -# post 5.0 natdepfiles. > -NATDEPFILES+= thread-db.o lin-lwp.o proc-service.o > +NATDEPFILES= infptrace.o inftarg.o fork-child.o corelow.o s390-nat.o \ > + core-aout.o core-regset.o linux-proc.o gcore.o thread-db.o lin-lwp.o \ > + proc-service.o > LOADLIBES = -ldl -rdynamic > > > > Andreas. > > -- > Andreas Schwab, SuSE Labs, schwab@suse.de > SuSE GmbH, Deutschherrnstr. 15-19, D-90429 Nürnberg > Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different." > -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer