Re: S390[x] configuration update

Daniel Jacobowitz
2002-04-28T00:25:14Z

On Sun, Apr 28, 2002 at 02:13:34AM +0200, Andreas Schwab wrote:
> Daniel Jacobowitz <drow@mvista.com> writes:
>
> |> On Sun, Apr 28, 2002 at 12:41:03AM +0200, Andreas Schwab wrote:
> |> > This updates the S390/S390x configuration to follow the latest wisdom.
> |> >
> |> > 2002-04-28 Andreas Schwab <schwab@suse.de>
> |> >
> |> > * config/s390/s390.mh (NATDEPFILES): Remove slib.o and
> |> > core-regset.o, add linux-proc.o and gcore.o.
> |>
> |> Er.... what? Why remove solib.o and core-regset.o?
>
> solib.o is in TDEPFILES, the same as all other linux targets. But
> removing core-regset.o was wrong. Misunderstanding from my side, sorry.

Oh, right. I forgot that it had moved.

> |> Also, I bet you didn't build test this.
>
> Of course, I did. But I forgot to test corefile functionality.
>
> Btw, config/i386/linux.mh NATDEPFILES lists linux-proc.o twice.

I wonder why I thought that... I was assuming you hadn't added
linux-proc.o, which you obviously did. Sorry. The updated patch looks
good to me; you can probably just commit it, since it fixes a build
failure and is quite straightforward.

> 2002-04-28 Andreas Schwab <schwab@suse.de>
>
> * config/s390/s390.mh (NATDEPFILES): Remove slib.o, add
> linux-proc.o and gcore.o.

"solib.o"

>
> --- gdb/config/s390/s390.mh 2002/04/27 18:51:58 1.1
> +++ gdb/config/s390/s390.mh 2002/04/27 23:42:01
> @@ -4,9 +4,9 @@ XM_FILE= xm-linux.h
> XM_CLIBS=
>
> NAT_FILE= nm-linux.h
> -NATDEPFILES= infptrace.o solib.o inftarg.o fork-child.o corelow.o s390-nat.o core-aout.o core-regset.o
> -# post 5.0 natdepfiles.
> -NATDEPFILES+= thread-db.o lin-lwp.o proc-service.o
> +NATDEPFILES= infptrace.o inftarg.o fork-child.o corelow.o s390-nat.o \
> + core-aout.o core-regset.o linux-proc.o gcore.o thread-db.o lin-lwp.o \
> + proc-service.o
> LOADLIBES = -ldl -rdynamic
>
>
>
> Andreas.
>
> --
> Andreas Schwab, SuSE Labs, schwab@suse.de
> SuSE GmbH, Deutschherrnstr. 15-19, D-90429 NÃ¼rnberg
> Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
>

--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer