From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3336 invoked by alias); 25 Apr 2002 01:04:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3293 invoked from network); 25 Apr 2002 01:04:04 -0000 Received: from unknown (HELO dr-evil.shagadelic.org) (208.176.2.162) by 209.249.29.67 with SMTP; 25 Apr 2002 01:04:04 -0000 Received: by dr-evil.shagadelic.org (Postfix, from userid 7518) id BBD019869; Wed, 24 Apr 2002 18:03:52 -0700 (PDT) Date: Wed, 24 Apr 2002 18:04:00 -0000 From: Jason R Thorpe To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Use multi-arch'd START_INFERIOR_TRAPS_EXPECTED on Alpha target Message-ID: <20020424180352.B26223@dr-evil.shagadelic.org> Reply-To: thorpej@wasabisystems.com Mail-Followup-To: Jason R Thorpe , Andrew Cagney , gdb-patches@sources.redhat.com References: <20020421181544.S1627@dr-evil.shagadelic.org> <3CC74887.2070401@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3CC74887.2070401@cygnus.com>; from ac131313@cygnus.com on Wed, Apr 24, 2002 at 08:06:31PM -0400 Organization: Wasabi Systems, Inc. X-SW-Source: 2002-04/txt/msg00995.txt.bz2 On Wed, Apr 24, 2002 at 08:06:31PM -0400, Andrew Cagney wrote: > #define STARTUP_WITH_SHELL 1 > - #define START_INFERIOR_TRAPS_EXPECTED (STARTUP_WITH_SHELL + 1) > > Does STARTUP_WITH_SHELL need to be multi-arched? > > I'm wondering if it would be better to make it a variable (``set > startup-with-shell ''). Looking at its uses it appears that > fork-child.c:startup_inferior() would still work (if it did previously). Hm. Actually, it occurs to me that this is more like what we want, but not quite. What we really want is: STARTUP_WITH_SHELL_ADDS_TRAPS So, then we get: #define START_INFERIOR_TRAPS_EXPECTED \ (startup_with_shell ? (STARTUP_WITH_SHELL_ADDS_TRAPS + 1) : 1) I.e. the issue is really how many extra traps the shell adds. -- -- Jason R. Thorpe