From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19286 invoked by alias); 24 Apr 2002 19:40:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19236 invoked from network); 24 Apr 2002 19:40:16 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 24 Apr 2002 19:40:16 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 170Scm-0005Yp-00 for ; Wed, 24 Apr 2002 15:40:20 -0400 Date: Wed, 24 Apr 2002 12:40:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered(gdb_stderr,... in hpread.c Message-ID: <20020424154020.A21219@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <4.2.0.58.20020424151049.01eb0900@ics.u-strasbg.fr> <3CC6FE52.F517979E@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CC6FE52.F517979E@redhat.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00970.txt.bz2 On Wed, Apr 24, 2002 at 11:49:54AM -0700, Michael Snyder wrote: > Pierre Muller wrote: > > > > This is a second of the files that I listed in > > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html > > as still having direct uses of stderr. > > > > I did not fix a 80 char overflow, because I didn't find a good way to do it: > > If I try to align the string "Psymtab for %s already read in. Shouldn't happen.\n" > > with gdb_stderr, I still get an overflow, how show I indent the args then? > > Should I break the string constant? > > I've spent more time agonizing over such questions than I care to > admit. ;-) > And I'm fairly strongly opinionated against greater-than-80-char lines. > But I think when it comes to printf and string constants, we have to be > a little loose about it. > > If you wanted to do something really perverted, you could try this: > > fprintf_unfiltered (gdb_stderr, > "Psymtab for %s %s %s\n", > pst->filename, > "already read in. ", > "Shouldn't happen."); Please don't... if we someday actually use i18n, we'll just have to kill all of these anyway. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer