From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4079 invoked by alias); 24 Apr 2002 14:25:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4006 invoked from network); 24 Apr 2002 14:25:09 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 24 Apr 2002 14:25:09 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 170Nhs-0001oS-00 for ; Wed, 24 Apr 2002 10:25:16 -0400 Date: Wed, 24 Apr 2002 07:25:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c Message-ID: <20020424102516.C6310@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <4.2.0.58.20020424151049.01eb0900@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4.2.0.58.20020424151049.01eb0900@ics.u-strasbg.fr> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00938.txt.bz2 On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote: > This is a second of the files that I listed in > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html > as still having direct uses of stderr. > > I did not fix a 80 char overflow, because I didn't find a good way to do it: > If I try to align the string "Psymtab for %s already read in. Shouldn't happen.\n" > with gdb_stderr, I still get an overflow, how show I indent the args then? > Should I break the string constant? Yes, I'd recommend: - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. " "Shouldn't happen.\n", -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer