Re: [RFA] More tweaks to arm_skip_prologue

Richard Earnshaw
2002-04-24T09:23:24Z

> Richard Earnshaw wrote:
> [...]
> > This should only ever be "str lr, [sp, #-4]!" (note the writeback).
>
> Richard, how's this revised patch?
>
> Do you think that, if we detect the str lr, [sp, -4]!
> we should just return pc + 4 immediately?

Well, there could be some stack allocation (and maybe some stores to it),
there might, in theory, be some floating point stacking as well.

>
> 2002-04-22 Michael Snyder <msnyder@redhat.com>
>
> * arm-tdep.c (arm_skip_prologue): Better handling for frameless
> functions. Treat "mov ip, sp" as optional. Recognize
> "str lr, [sp, #-4]".

Working on the principal that this is better than what we have, I think
this should go in. More needs to be done, but I don't think it should
block this change.

See, for example, the test case I posted in my previous message.