From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6767 invoked by alias); 25 Apr 2002 01:15:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6730 invoked from network); 25 Apr 2002 01:15:12 -0000 Received: from unknown (HELO pizda.ninka.net) (216.101.162.242) by 209.249.29.67 with SMTP; 25 Apr 2002 01:15:12 -0000 Received: from localhost (IDENT:davem@localhost.localdomain [127.0.0.1]) by pizda.ninka.net (8.9.3/8.9.3) with ESMTP id SAA03483; Wed, 24 Apr 2002 18:05:31 -0700 Date: Wed, 24 Apr 2002 18:15:00 -0000 Message-Id: <20020424.180531.51276912.davem@redhat.com> To: msnyder@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Improve Sparc epilogue analysis From: "David S. Miller" In-Reply-To: <3CC74F72.6B0F8C8B@redhat.com> References: <3CC73C70.A4BBA9D7@redhat.com> <20020424.170539.73357679.davem@redhat.com> <3CC74F72.6B0F8C8B@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00996.txt.bz2 From: Michael Snyder Date: Wed, 24 Apr 2002 17:36:02 -0700 The parts that are NOT mentioned in the changelog (your changes to the logic in sparc_init_extra_frame_info) are not OK, first because you didn't mention them in the changelog, and second because I can't convince myself that they are right. Michael, I hate keeping on about this, but I did mention them in my changes: (sparc_init_extra_frame_info): Use sparc_skip_prologue to find prologue bounds instead of looking at line number info by hand. I know you're going to explode at me, but you seem to make a lot of errors reviewing my changes. Please settle down, take your time. At this point I'd much rather you delay than review things haphazardly. Thank you.