From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11148 invoked by alias); 19 Apr 2002 22:58:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11073 invoked from network); 19 Apr 2002 22:58:10 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 19 Apr 2002 22:58:10 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16yhKv-0003nj-00; Fri, 19 Apr 2002 18:58:37 -0400 Date: Fri, 19 Apr 2002 15:58:00 -0000 From: Daniel Jacobowitz To: Jim Ingham Cc: gdb-patches@sources.redhat.com Subject: Re: Obvious fix in values.c? Message-ID: <20020419185837.A14276@nevyn.them.org> Mail-Followup-To: Jim Ingham , gdb-patches@sources.redhat.com References: <6D0E546A-53DC-11D6-8B7C-00039379E320@apple.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6D0E546A-53DC-11D6-8B7C-00039379E320@apple.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00643.txt.bz2 On Fri, Apr 19, 2002 at 02:28:44PM -0700, Jim Ingham wrote: > Do folks agree that this falls under the obvious fix rule? It doesn't > seem safe to assume that all demangled names will contain a space (and > in fact, gdb crashed on someone when the assumption was proved false...). > > 2002-04-19 Jim Ingham > > * values.c (value_headof): Don't assume all demangled names contain > a space. Could I please get you to solve this properly? Kill the one and only use of this function in printcmd.c via value_from_vtable_info. If you simply cast the pointer to a pointer to the proper base type, found via value_rtti_type, this function can die. It should just work (and/or be more useful than the current behavior). -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer