From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-14403-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 17298 invoked by alias); 19 Apr 2002 10:23:35 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 17283 invoked from network); 19 Apr 2002 10:23:31 -0000
Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3)
  by sources.redhat.com with SMTP; 19 Apr 2002 10:23:31 -0000
Received: by fw-cam.cambridge.arm.com; id LAA28981; Fri, 19 Apr 2002 11:23:29 +0100 (BST)
Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5)
	id xma028264; Fri, 19 Apr 02 11:22:39 +0100
Received: from cam-mail2.cambridge.arm.com (localhost [127.0.0.1])
	by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id LAA26348;
	Fri, 19 Apr 2002 11:22:38 +0100 (BST)
Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18])
	by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id LAA17555;
	Fri, 19 Apr 2002 11:22:37 +0100 (BST)
Message-Id: <200204191022.LAA17555@cam-mail2.cambridge.arm.com>
To: Michael Snyder <msnyder@cygnus.com>
cc: gdb-patches@sources.redhat.com, cagney@redhat.com, rearnsha@arm.com
Reply-To: Richard.Earnshaw@arm.com
Organization: ARM Ltd.
X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd)
X-Fax: +44 1223 400410
X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ.
X-Url: http://www.arm.com/
Subject: Re: [RFA] Arm: change #defines to enums 
In-reply-to: Your message of "Thu, 18 Apr 2002 15:14:46 PDT."
             <200204182214.g3IMEki03718@reddwarf.sfbay.redhat.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Fri, 19 Apr 2002 03:23:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
X-SW-Source: 2002-04/txt/msg00624.txt.bz2

> Is this OK with folks?
> 
> 2002-04-18  Michael Snyder  <msnyder@redhat.com>
> 
> 	* arm-tdep.h: Change defines to enums for ease of debugging.

I'm happy with the change to the regnums, but not with the other bits.  
The other fields are really parts of a bitmask, not separate enums.

For example, it doesn't make sense to me to have enums that should be 
orred together, as in FLAG_N | FLAG_Z.

I suspect that 

! enum gdb_condition_flag {
!   FLAG_N = 0x80000000,
!   FLAG_Z = 0x40000000,
!   FLAG_C = 0x20000000,
!   FLAG_V = 0x10000000
! };

will trip the problem with displaying enums with the top bit set on 32-bit 
platforms, so instead of making debugging easier, it will make it 
impossible. (There's a PR about it).

I also can't really see how 


! enum gdb_arm_const {
!   INT_REGISTER_RAW_SIZE = 4,
!   INT_REGISTER_VIRTUAL_SIZE = 4,
! 
...

will make debugging easier, in fact I would say it would be more 
confusing, since gdb won't know which one to use when displaying a value.

R.