Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: ac131313@cygnus.com
Cc: mec@shout.net, fnasser@redhat.com, cagney@cygnus.com,
	gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix xfail Sparc pattern
Date: Thu, 18 Apr 2002 15:04:00 -0000	[thread overview]
Message-ID: <20020418.145531.68100471.davem@redhat.com> (raw)
In-Reply-To: <3CBEF272.3060500@cygnus.com>

   From: Andrew Cagney <ac131313@cygnus.com>
   Date: Thu, 18 Apr 2002 12:21:06 -0400

   > Fernando Nasser writes:
   > 
   >> I wonder if we should activate this test and see where it fails and
   >> start marking as XFAILS (KFAILS actually) and entering a bug report 
   >> when we see the regressions.
   >
   > I think so.  The comment indicates that this is due to a problem
   > inside gdb, not a problem with the environment, so that XFAIL is wrong
   > in the first place.
   > 
   > This is the old "XFAIL means an external program is not functional"
   > versus "XFAIL means that gdb is wrong but it's too painful to fix"
   > argument.
   
   Sounds right to me.  The ``correct fix'' is convert the code to generic 
   dummy frames (which in turn means work on generic dummy frames) but both 
   of those are GDB bugs.
   
I agree too, mark it as expected to pass and use generic dummy frame
support to fixup targets that show up to fail the test.

In fact, even though I had been over this code a million times, I
failed to notice the generic dummy frame mechanism, and I in fact
reimplemented this in some of my pending Sparc64 fixes.  Thanks Andrew
for pointing this out!  I'll fixup Sparc to use this before I submit
that Sparc64 fixes I have pending.


  reply	other threads:[~2002-04-18 22:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-18  9:06 Michael Elizabeth Chastain
2002-04-18  9:21 ` Andrew Cagney
2002-04-18 15:04   ` David S. Miller [this message]
2002-04-18 15:29     ` Andrew Cagney
2002-04-18 15:37       ` David S. Miller
2002-04-18 16:25         ` Andrew Cagney
  -- strict thread matches above, loose matches on Subject: below --
2002-04-17 12:57 David S. Miller
2002-04-18  7:48 ` Fernando Nasser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020418.145531.68100471.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=ac131313@cygnus.com \
    --cc=cagney@cygnus.com \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox