From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29715 invoked by alias); 16 Apr 2002 16:56:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29697 invoked from network); 16 Apr 2002 16:56:23 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 16 Apr 2002 16:56:23 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16xWG6-0006cj-00; Tue, 16 Apr 2002 12:56:46 -0400 Date: Tue, 16 Apr 2002 09:56:00 -0000 From: Daniel Jacobowitz To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: gdb.asm/asm-source.exp creation of arch.inc doesn't work for relative ${srcdir} Message-ID: <20020416125646.A25162@nevyn.them.org> Mail-Followup-To: Elena Zannoni , gdb-patches@sources.redhat.com References: <20020416010713.A32200@nevyn.them.org> <15548.13764.336835.513002@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15548.13764.336835.513002@localhost.redhat.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00556.txt.bz2 On Tue, Apr 16, 2002 at 10:31:32AM -0400, Elena Zannoni wrote: > Daniel Jacobowitz writes: > > ${srcdir} in the testsuite is for gdb/testsuite/; but a symbolic link in > > gdb.asm needs to have an extra '..' if it's an absolute path. I always > > configure as '../srcdir/configure', so this breaks for me. > > > > Ahhh, relative paths! I gave up on those. Sometimes I was seeing odd > testsuite failures due to that. Anyway.... > > > Do you think creating the link in objdir/gdb/testsuite/ instead would be a > > good solution? I can't think of another portable one. > > > > How about the following. Somebody reminded me that there is no > technical reason to use a symlink at all. I tried with relative and > absolute paths, and seems to work fine. Can you try it? It works, with one caveat: > Index: asm-source.exp > =================================================================== > RCS file: /cvs/uberbaum/gdb/testsuite/gdb.asm/asm-source.exp,v > retrieving revision 1.21 > diff -u -p -r1.21 asm-source.exp > --- asm-source.exp 8 Apr 2002 00:01:06 -0000 1.21 > +++ asm-source.exp 16 Apr 2002 14:27:16 -0000 > @@ -87,9 +87,7 @@ set binfile ${objdir}/${subdir}/${testfi > set src1 ${srcdir}/${subdir}/asmsrc1.s > set src2 ${srcdir}/${subdir}/asmsrc2.s > > -set insn_file ${srcdir}/${subdir}/${asm-arch}.inc > -remote_exec build "rm -f ${objdir}/${subdir}/arch.inc" Please don't delete this line. If you remote_download onto a dangling symlink, you get an error. I don't know what happens if you remote download onto a normal symlink, but it runs a risk of clobbering something in ${srcdir}. > -remote_exec build "ln -s ${insn_file} ${objdir}/${subdir}/arch.inc" > +remote_download host ${srcdir}/${subdir}/${asm-arch}.inc ${subdir}/arch.inc > > if { "${asm-flags}" == "" } { > #set asm-flags "-Wa,-gstabs,-I${srcdir}/${subdir},-I${objdir}/${subdir}" > @@ -278,3 +276,4 @@ gdb_test "print staticvar" ".* = 5" "loo > gdb_test "disassem foostatic" ".*:.*End of assembler dump." \ > "look at static function" > > +remote_exec build "rm -f ${objdir}/${subdir}/arch.inc" > -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer