Re: [RFA] Save SSE registers to generated core files, without breaking other architectures

Daniel Jacobowitz
2002-04-15T01:51:58Z

On Sun, Apr 14, 2002 at 06:22:13PM -0400, Andrew Cagney wrote:
> >Daniel Jacobowitz wrote:
> >
> >>
> >>How does this patch look? The original problem was that we can not rely
> >>on
> >>HAVE_PTRACE_FPXREGSET, because the presence of PTRACE_FPXREGSET doesn't
> >>imply that GDB has a fill_fpxregset function available. I updated it to
> >>check for a separate flag. It's not ideal, but until we separate regset
> >>handling into an appropriate vector, it's the best we can do (I think).
> >>
> >>OK?
> >
> >
> >Well, I like it (and thanks for working on it),
> >but Andrew might have something to say about adding
> >a new macro. Andrew?
>
>
> >>* config/i386/tm-linux.h: Define FILL_FPXREGSET.
>
> linux-proc.c is only built native so I think FILL_.. should only be
> defined for native builds => config/i386/nm-linux.h.
>
> Having #ifdef code enabled via a tm.h file macro just feels wrong.

And the function in question is even in i386-linux-nat.c. nm-linux.h
sounds like the right place to put it. OK with that change, then?

--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer