From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10994 invoked by alias); 15 Apr 2002 01:51:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10977 invoked from network); 15 Apr 2002 01:51:56 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 15 Apr 2002 01:51:56 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16wvf6-0006ZM-00; Sun, 14 Apr 2002 21:52:08 -0400 Date: Sun, 14 Apr 2002 18:51:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [RFA] Save SSE registers to generated core files, without breaking other architectures Message-ID: <20020414215208.B25085@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Michael Snyder , gdb-patches@sources.redhat.com References: <20020402145546.A7582@nevyn.them.org> <3CAA274A.C0170CF@redhat.com> <3CBA0115.70009@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CBA0115.70009@cygnus.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00520.txt.bz2 On Sun, Apr 14, 2002 at 06:22:13PM -0400, Andrew Cagney wrote: > >Daniel Jacobowitz wrote: > > > >> > >>How does this patch look? The original problem was that we can not rely > >>on > >>HAVE_PTRACE_FPXREGSET, because the presence of PTRACE_FPXREGSET doesn't > >>imply that GDB has a fill_fpxregset function available. I updated it to > >>check for a separate flag. It's not ideal, but until we separate regset > >>handling into an appropriate vector, it's the best we can do (I think). > >> > >>OK? > > > > > >Well, I like it (and thanks for working on it), > >but Andrew might have something to say about adding > >a new macro. Andrew? > > > >>* config/i386/tm-linux.h: Define FILL_FPXREGSET. > > linux-proc.c is only built native so I think FILL_.. should only be > defined for native builds => config/i386/nm-linux.h. > > Having #ifdef code enabled via a tm.h file macro just feels wrong. And the function in question is even in i386-linux-nat.c. nm-linux.h sounds like the right place to put it. OK with that change, then? -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer