From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21550 invoked by alias); 10 Apr 2002 00:54:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21265 invoked from network); 10 Apr 2002 00:53:58 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 10 Apr 2002 00:53:58 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16v6N8-0004ls-00; Tue, 09 Apr 2002 20:54:02 -0400 Date: Tue, 09 Apr 2002 17:54:00 -0000 From: Daniel Jacobowitz To: Jim Ingham Cc: gdb-patches@sources.redhat.com Subject: Re: add set cp-abi command Message-ID: <20020409205402.A18266@nevyn.them.org> Mail-Followup-To: Jim Ingham , gdb-patches@sources.redhat.com References: <20020322140939.A26911@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00391.txt.bz2 On Tue, Apr 09, 2002 at 05:27:19PM -0700, Jim Ingham wrote: > I got distracted from this for a little while... Here is a final > version with something in the texi file as well. > > ChangeLog: > > 2002-03-12 James Ingham > > * cp-abi.c (set_cp_abi_cmd, show_cp_abi_cmd,): New functions, > allow you to set & show cplus abi's in case gdb gets it wrong. > (set_cp_abi_as_auto_default): New function, set the "auto" abi > to be this abi. > (is_cp_abi_auto_p): New function, say whether the current abi > is the default or not. > (_initialize_cp_abi): Define the cp-abi switching commands. > * cp-abi.h: declare the new functions. > * minsyms.c (install_minimal_symbols): don't switch the cp_abi > unless the current abi is auto. > * gnu-v2-abi.c (_initialize_gnu_v2_abi): don't switch to gnu-v2, > but set it as the auto_default instead. > > Okay to check in? I think we may have misplaced a revision here... ! internal_error (__FILE__, __LINE__, ! "Too many CP ABIs, please increase CP_ABI_MAX in cp-abi.c"); C++ ABIs. ! char *longname; /* These two can't be const, because I need to */ ! char *doc; /* change the name for the auto abi. */ GNU comment formatting. Something like: /* These two are not constant because they are changed at runtime for the auto ABI. */ char *longname; char *doc; More importantly: ! if (cp_abi_is_auto_p ()) ! set_cp_abi_as_auto_default ("gnu-v3"); Shouldn't you lose the cp_abi_is_auto_p () check there? If you agree with all three, feel free to update them and check it in. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer