From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10152 invoked by alias); 8 Apr 2002 19:24:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10145 invoked from network); 8 Apr 2002 19:24:39 -0000 Received: from unknown (HELO localhost.localdomain) (12.230.181.242) by sources.redhat.com with SMTP; 8 Apr 2002 19:24:39 -0000 Received: from there (DRAGON [127.0.0.1]) by localhost.localdomain (8.11.6/8.11.6) with SMTP id g38JO0v24874; Mon, 8 Apr 2002 12:24:00 -0700 Message-Id: <200204081924.g38JO0v24874@localhost.localdomain> Content-Type: text/plain; charset="iso-8859-1" From: "Martin M. Hunt" Organization: Red Hat Inc To: Michael Snyder Subject: Re: [RFA] breakpoints.c clear_command fix Date: Mon, 08 Apr 2002 12:24:00 -0000 Cc: gdb-patches@sources.redhat.com, eliz@is.elta.co.il References: <200203270001.g2R01sJ08019@localhost.localdomain> <3CAE5578.10B51383@redhat.com> In-Reply-To: <3CAE5578.10B51383@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2002-04/txt/msg00317.txt.bz2 On Friday 05 April 2002 05:55 pm, Michael Snyder wrote: > "Martin M. Hunt" wrote: > > The clear command improperly detects overlays and fails > > to clear breakpoints if overlays are not disabled. > > > > Tested with linux-x-mips (overlays enabled) and linux x86 native. > > Martin, you really made me think with this one. Sorry it took so long. > I had to go back eleven years in the code base to understand what this > code was trying to do -- which made me realize that it's painfully > obsolete. It has two inner loops with identical control conditions > (except that they've gotten out of sync), just because they didn't > have ALL_BREAKPOINTS_SAFE when this code was written. I was wondering why the two seperate loops. I didn't understand the comments so I made the minimum changes that seemed logical. > So I rewrote the whole damn function. ;-) Great! It looks fine and it passes all my test cases. Thanks. -- Martin Hunt GDB Engineer Red Hat, Inc.