Re: PATCH: Further gdbserver cleanups

Daniel Jacobowitz
2002-04-06T19:31:07Z

On Sat, Apr 06, 2002 at 02:23:02PM -0500, Andrew Cagney wrote:
> >This patch adds -Wall to gdbserver's build options, cleans up everything
> >that it turned up, and adds the beginnings of a target stack. It also adds
> >a simplistic mechanism to track child processes opaquely; for instance, for
> >per-child regcaches. No real new functionality here, but it should be
> >pretty obvious where I'm going. The next batch of changes are likely to be
> >more interesting.
>
> Er, there are still two commits in there.

I was going to do it as two commits, but separating it out again seemed
pointless. I'll do it if you prefer; it's just a little work playing
with my changelogs.

> Rather than ``-Wall'' just ,-Werror as with the rest of GDB. See:
> http://sources.redhat.com/gdb/onlinedocs/gdbint_13.html#SEC104

I haven't added the configury for ,-Werror yet. I'll do that soon.
The way that gdbserver is implemented (and for most of the what I see
changing in the near future) it does not have the motivation that GDB
has to avoid -Wunused-parameter; so I went with -Wall by default, which
is stronger. If you'd prefer that I be consistent with the rest of GDB
I've no objection.

> (Oh, also, at present ARI skips that directory.)

As it should, I think. Things have different names in gdbserver land;
ARI would have to be trimmed a bit for it, probably.

> >I'll check this in in a day or two if no one objects (well, and when Andrew
> >thinks it's been long enough and checks in the relevant MAINTAINERS patch).
>
> Oops. I'd better drain last weeks patch postings ...
>
> Andrew