From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29967 invoked by alias); 4 Apr 2002 20:30:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29957 invoked from network); 4 Apr 2002 20:29:59 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 4 Apr 2002 20:29:59 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16tDry-0004Bz-00 for ; Thu, 04 Apr 2002 15:30:06 -0500 Date: Thu, 04 Apr 2002 12:30:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Let dwarf2 CFI's execute_stack_op be used outside of CFI Message-ID: <20020404153006.A15980@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00125.txt.bz2 On Thu, Apr 04, 2002 at 03:24:44PM -0500, Daniel Berlin wrote: > So i'm implementing this, and want to know > ... > > /* Return the value N values down from the top of CONTEXT's stack. > > This raises an error if there aren't at least N+1 values on the stack. */ > > ADDR_TYPE dwarf_expr_fetch (struct dwarf_expr_context *context, int n); > > > > How would you like me to raise the error? > Should i add an error handling function to the dwarf_expr_context struct? > Or just call "error", under the assumption that any libdwarf library we > write would have error functions of it's own (all the libdwarf's do), and > that it'll be the typical printf arguments error function. [If you go for the latter, please document it clearly in some header....] -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer