From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17528 invoked by alias); 4 Apr 2002 06:01:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17520 invoked from network); 4 Apr 2002 06:01:12 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 4 Apr 2002 06:01:12 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16t0J6-0003da-00; Thu, 04 Apr 2002 01:01:12 -0500 Date: Wed, 03 Apr 2002 22:01:00 -0000 From: Daniel Jacobowitz To: Michael Elizabeth Chastain , Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] import drow dbxread.c fix to branch Message-ID: <20020404010112.A13460@nevyn.them.org> Mail-Followup-To: Michael Elizabeth Chastain , Andrew Cagney , gdb-patches@sources.redhat.com References: <200204040536.g345a6t30923@duracef.shout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200204040536.g345a6t30923@duracef.shout.net> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00103.txt.bz2 On Wed, Apr 03, 2002 at 11:36:06PM -0600, Michael Elizabeth Chastain wrote: > DanielJ writes: > > Only shows on GCC 3.1, eh? I'll try to look at it later, but I have no > > post-3.0 toolchain installed right now. Actually, I should > > investigate, to make sure it isn't a 3.1 regression... > > On the next spin, I'll make a special report of regressions for gcc > 3.0.4 versus gcc-3_1-branch. You can already look at "difference by gcc" > in the regular report if you want to pick up a hot spot or two. > > BTW my test harness now saves the whole test directory, including all > the executable files. In fact I'll just throw some tarball up in my > ftp directory in case it might help someone: > > ftp://ftp.shout.net/pub/users/mec/gdb/for-pr-gdb-381.tar.gz > ftp://ftp.shout.net/pub/users/mec/gdb/for-pr-gdb-381-src.tar.gz Thanks. It does help - that was pretty easy, actually :). I've found the bug; mi-cmd-disassemble does not recognize '0' line numbers, and it needs to. I don't know why only 3.1 triggers this. Probably a function padding thing; the end of the previous function seems to share a PC with the beginning of the one being listed. Here's a patch; Andrew, how's this look? -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer 2002-04-04 Daniel Jacobowitz * mi-cmd-disas.c (mi_cmd_disassemble): Skip end-of-function markers in the line table. Index: mi/mi-cmd-disas.c =================================================================== RCS file: /cvs/src/src/gdb/mi/mi-cmd-disas.c,v retrieving revision 1.12 diff -u -p -r1.12 mi-cmd-disas.c --- mi-cmd-disas.c 2002/01/05 04:30:46 1.12 +++ mi-cmd-disas.c 2002/04/04 05:59:51 @@ -332,6 +332,10 @@ mi_cmd_disassemble (char *command, char && le[i].pc == le[i + 1].pc) continue; /* Ignore duplicates */ + /* Skip any end-of-function markers. */ + if (le[i].line == 0) + continue; + mle[newlines].line = le[i].line; if (le[i].line > le[i + 1].line) out_of_order = 1;