From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22233 invoked by alias); 3 Apr 2002 01:01:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22226 invoked from network); 3 Apr 2002 01:01:38 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 3 Apr 2002 01:01:38 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16sZ9g-0005gr-00; Tue, 02 Apr 2002 20:01:40 -0500 Date: Tue, 02 Apr 2002 17:01:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sources.redhat.com, Andrew Cagney Subject: Re: [RFA/mi-testsuite] XFAIL mi*-console.exp Message-ID: <20020402200140.A21552@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sources.redhat.com, Andrew Cagney References: <20020402194252.A20826@nevyn.them.org> <3CAA4F86.7CE409C8@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CAA4F86.7CE409C8@redhat.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00048.txt.bz2 On Tue, Apr 02, 2002 at 04:40:38PM -0800, Michael Snyder wrote: > Daniel Jacobowitz wrote: > > > > These tests are testing for a feature that exists either nowhere or just in > > simulators and some remote stubs: that the inferior's output goes through > > GDB and is properly encoded by the MI layer. Since support isn't there for > > many remote debugging stubs or for native, I think these two tests should be > > XFAIL'd. Does that make sense, Andrew? If so, OK to commit this? > > There is a dejagnu variable that you can use to see > whether this is supported... lemme see... > > Ah -- here you go. You want to do something like the following: > > if { ![gdb_skip_stdio_test "Hello message"] } then { > do the "hello message" test... Isn't gdb_skip_stdio_test for things where there's no way at all to see the output? grep, grep,... if [target_info exists gdb,noinferiorio] { That's not quite the same thing. You can run stdio test on a native target, and (while GDB never sees the output) DejaGNU will. I could do this instead, though... revised patch attached. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer 2002-04-02 Daniel Jacobowitz * gdb.mi/mi-console.exp: Accept native console output as an XFAIL. Don't run the test if we don't have inferior IO. * gdb.mi/mi0-console.exp: Likewise. Index: testsuite/gdb.mi/mi-console.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-console.exp,v retrieving revision 1.7 diff -u -p -r1.7 mi-console.exp --- mi-console.exp 2001/08/19 01:23:43 1.7 +++ mi-console.exp 2002/04/03 01:00:34 @@ -79,7 +79,8 @@ gdb_expect { } } -gdb_expect { +if {![gdb_skip_stdio_test "Hello message"]} { + gdb_expect { -re "@\"H\"\r\n.*@\"e\"\r\n.*@\"l\"\r\n.*@\"l\"\r\n.*@\"o\"\r\n.*@\" \"\r\n.*@\"\\\\\\\\\"\r\n.*@\"\\\\\"\"\r\n.*@\"!\"\r\n.*@\"\\\\r\"\r\n.*@\"\\\\n\"\r\n" { pass "Hello message" } @@ -92,11 +93,12 @@ gdb_expect { # multiple event sources to channel the output back through the # MI. - fail "Hello message (known bug)" + xfail "Hello message (known limitation)" } timeout { fail "Hello message (timeout)" } + } } gdb_expect { Index: testsuite/gdb.mi/mi0-console.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi0-console.exp,v retrieving revision 1.5 diff -u -p -r1.5 mi0-console.exp --- mi0-console.exp 2001/08/19 01:23:43 1.5 +++ mi0-console.exp 2002/04/03 01:00:34 @@ -79,7 +79,8 @@ gdb_expect { } } -gdb_expect { +if {![gdb_skip_stdio_test "Hello message"]} { + gdb_expect { -re "@\"H\"\r\n.*@\"e\"\r\n.*@\"l\"\r\n.*@\"l\"\r\n.*@\"o\"\r\n.*@\" \"\r\n.*@\"\\\\\\\\\"\r\n.*@\"\\\\\"\"\r\n.*@\"!\"\r\n.*@\"\\\\r\"\r\n.*@\"\\\\n\"\r\n" { pass "Hello message" } @@ -92,11 +93,12 @@ gdb_expect { # multiple event sources to channel the output back through the # MI. - fail "Hello message (known bug)" + xfail "Hello message (known limitation)" } timeout { fail "Hello message (timeout)" } + } } gdb_expect {