From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12900 invoked by alias); 2 Apr 2002 20:23:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12882 invoked from network); 2 Apr 2002 20:23:38 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 2 Apr 2002 20:23:38 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16sUob-0002T9-00; Tue, 02 Apr 2002 15:23:37 -0500 Date: Tue, 02 Apr 2002 12:23:00 -0000 From: Daniel Jacobowitz To: Nathanael Nerode Cc: gdb-patches@sources.redhat.com Subject: Re: spu autoconfiscation patch Message-ID: <20020402152337.A9268@nevyn.them.org> Mail-Followup-To: Nathanael Nerode , gdb-patches@sources.redhat.com References: <20020402195614.GA10282@doctormoo.dyndns.org> <3CAA0EA8.C3FBD6D2@apple.com> <20020402201505.GA10410@doctormoo.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020402201505.GA10410@doctormoo.dyndns.org> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00038.txt.bz2 On Tue, Apr 02, 2002 at 03:15:05PM -0500, Nathanael Nerode wrote: > Daniel, thanks for the pointers... I've had this patch sitting for a > while and ASSumed I'd got the diff format right the > first time I posted it. (No sort of diff is very readable, though, > because more of the file changed than stayed the same.) And I > think the ChangeLog entry in my original post was more correct, but I > couldn't find it and rewrote it very quickly. :-P Sorry to cause > trouble... No problem. I checked in a corrected version. Also, you should remember that # is not a comment character in configure.in. The only reason it worked for you was because you didn't have spaces between # and AC, I think. M4 comments start with 'dnl'. Here's what went in. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer Index: ChangeLog =================================================================== RCS file: /cvs/src/src/utils/spu/ChangeLog,v retrieving revision 1.5 diff -u -p -r1.5 ChangeLog --- ChangeLog 2000/07/31 12:54:31 1.5 +++ ChangeLog 2002/04/02 20:22:47 @@ -1,3 +1,10 @@ +2002-04-02 Daniel Jacobowitz + + From Nathanael Nerode : + * utils/spu/configure.in: Autoconfiscated. + * utils/spu/Makefile.in: Autoconfiscated. + * utils/spu/configure: New generated file. + 2000-07-21 Stan Shebs Add the generation of C++ classes. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/utils/spu/Makefile.in,v retrieving revision 1.1.1.1 diff -u -p -r1.1.1.1 Makefile.in --- Makefile.in 1999/04/16 01:35:29 1.1.1.1 +++ Makefile.in 2002/04/02 20:22:47 @@ -1,6 +1,6 @@ -# Copyright 1993, 1994 Free Software Foundation, Inc. +# Copyright 1993, 1994, 2002 Free Software Foundation, Inc. -# This file is part of GNU CC. +# This file is part of SPU. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -15,17 +15,23 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. +VPATH = @srcdir@ -prefix = /usr/local +SHELL = /bin/sh -program_transform_name = -exec_prefix = $(prefix) -bindir = $(exec_prefix)/bin -libdir = $(exec_prefix)/lib -tooldir = $(libdir)/$(target_alias) +prefix = @prefix@ +exec_prefix = @exec_prefix@ +bindir = @bindir@ +libdir = @libdir@ +datadir = @datadir@ +mandir = @mandir@ +infodir = @infodir@ +includedir = @includedir@ +srcdir = @srcdir@ + +CC = @CC@ +CFLAGS = @CFLAGS@ -datadir = $(prefix)/share -mandir = $(prefix)/man man1dir = $(mandir)/man1 man2dir = $(mandir)/man2 man3dir = $(mandir)/man3 @@ -35,27 +41,15 @@ man6dir = $(mandir)/man6 man7dir = $(mandir)/man7 man8dir = $(mandir)/man8 man9dir = $(mandir)/man9 -infodir = $(prefix)/info -includedir = $(prefix)/include - -SHELL = /bin/sh +tooldir = $(libdir)/$(target_alias) -INSTALL = install -c +INSTALL = @INSTALL@ INSTALL_PROGRAM = $(INSTALL) INSTALL_DATA = $(INSTALL) -AR = ar -AR_FLAGS = qv -RANLIB = ranlib - -# Directory containing source files. Don't clean up the spacing, -# this exact string is matched for by the "configure" script. -srcdir = . - # Where is the "include" directory? Traditionally ../include or ./include -INCLUDE_DIR = ${srcdir}/../../include -INCLUDE_DEP = $$(INCLUDE_DIR) +INCLUDE_DIR = ${srcdir}/../../include # All the includes used for CFLAGS and for lint. # -I. for config files. @@ -64,61 +58,39 @@ INCLUDE_DEP = $$(INCLUDE_DIR) INCLUDE_CFLAGS = -I. -I${srcdir} -I${srcdir}/config -I$(INCLUDE_DIR) -# CFLAGS is specifically reserved for setting from the command line -# when running make. I.E. "make CFLAGS=-Wmissing-prototypes". - -CFLAGS = -g - # ALL_CFLAGS is the aggregate of all other *CFLAGS macros. - -ALL_CFLAGS = $(CFLAGS) $(INCLUDE_CFLAGS) - -# None of the things in CFLAGS will do any harm, and on some systems -# (e.g. SunOS4) it is important to use the MH_CFLAGS. - -LDFLAGS = $(CFLAGS) -# Where is the "-liberty" library, containing getopt and obstack? +ALL_CFLAGS = @DEFS@ $(INCLUDE_CFLAGS) $(CFLAGS) -LIBIBERTY_DIR = ${srcdir}/../../libiberty -LIBIBERTY = ./../../libiberty${subdir}/libiberty.a - -# Host and target-dependent makefile fragments come in here. -#### -# End of host and target-dependent makefile fragments - -# Prevent Sun make from putting in the machine type. Setting -# TARGET_ARCH to nothing works for SunOS 3, 4.0, but not for 4.1. - -.c.o: - ${CC} -c ${ALL_CFLAGS} $< - -OFILES = spu.o - all: spu info: install: - -install-info: -spu: ${OFILES} +spu: spu.o $(CC) $(CFLAGS) -o spu spu.o -spu.o: spu.c +# Prevent Sun make from putting in the machine type. Setting +# TARGET_ARCH to nothing works for SunOS 3, 4.0, but not for 4.1. +spu.o: $(srcdir)/spu.c + ${CC} -c ${ALL_CFLAGS} $(srcdir)/spu.c mostlyclean: -clean: mostlyclean +clean: mostlyclean rm -f *.o spu + +distclean: clean + rm -f Makefile config.status config.log config.cache -distclean: clean - rm -f Makefile config.status +maintainer-clean realclean: distclean -maintainer-clean realclean: distclean +Makefile: $(srcdir)/Makefile.in config.status + ./config.status -Makefile: Makefile.in $(host_makefile_frag) $(target_makefile_frag) - $(SHELL) config.status +config.status: $(srcdir)/configure + ./config.status --recheck -force: +$(srcdir)/configure: $(srcdir)/configure.in + cd $(srcdir) && autoconf cvs server: configure is a new entry, no comparison available Index: configure.in =================================================================== RCS file: /cvs/src/src/utils/spu/configure.in,v retrieving revision 1.1.1.1 diff -u -p -r1.1.1.1 configure.in --- configure.in 1999/04/16 01:35:30 1.1.1.1 +++ configure.in 2002/04/02 20:22:48 @@ -1,13 +1,40 @@ -# This file is a shell script fragment that supplies the information -# necessary to tailor a template configure script into the configure -# script appropriate for this directory. For more information, check -# any existing configure script. +# Process this file with autoconf to produce a configure script. -srctrigger=spu.c -srcname="spu" +# Copyright 2002 Free Software Foundation, Inc. -# per-host: +# This file is part of SPU. -# per-target: +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -# post-target: +AC_INIT([spu.c]) + +# Checks for programs. +AC_PROG_CC +AC_PROG_INSTALL + +dnl # Checks for header files. +dnl # The program doesn't actually handle failure. +dnl AC_HEADER_STDC +dnl AC_CHECK_HEADERS([stdlib.h string.h]) + +# Checks for typedefs, structures, and compiler characteristics. +AC_C_CONST + +dnl # Checks for library functions. +dnl # The program doesn't actually handle failure. +dnl AC_FUNC_MALLOC +dnl AC_CHECK_FUNCS([memset strtol]) + +AC_OUTPUT([Makefile])