From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1073 invoked by alias); 2 Apr 2002 20:04:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1066 invoked from network); 2 Apr 2002 20:04:57 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 2 Apr 2002 20:04:57 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16sUWa-00029Y-00 for ; Tue, 02 Apr 2002 15:05:00 -0500 Date: Tue, 02 Apr 2002 12:04:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: spu autoconfiscation patch Message-ID: <20020402150500.B8031@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20020402195614.GA10282@doctormoo.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020402195614.GA10282@doctormoo.dyndns.org> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00034.txt.bz2 On Tue, Apr 02, 2002 at 02:56:14PM -0500, Nathanael Nerode wrote: > Reposting... > > 'configure' is not included in the patch below because I couldn't get > cvs diff to handle a new file. It's generated from configure.in anyway. > > The whole files are probably easier to read than the diffs. Please don't use straight diff; it's unreadable. Use contextual or unified diffs - I think the preference for most GNU projects is contextual (I'm a unified person, myself....) > I did not attempt to cure any bugs or portability issues in SPU, as I > do not feel that I am a competent enough C programmer to do so; this is > just enough that the 'utils' and top level autoconfiscations will be > possible. > > With this patch, spu configures, builds, and has no behavior changes on > my Debian woody system (i686-pc-linux-gnu). (The programs which SPU > generates are identical before and after.) > > Apr 2 2002 Nathanael Nerode You also may want to look at GNU changelog formatting. That should be: 2002-04-02 Nathanael Nerode (note the double spaces) > * utils/spu/configure.in: autoconfiscated. > * utils/spu/Makefile.in: autoconfiscated. > * utils/spu/configure: new autoconf-generated file. GDB folks: This patch is simple and seems obviously correct to me. Since I'm allowed to check in changes to configury, I'm going to sit on this for two or three days, and check it in to the trunk if there are no objections. Speak now or, etc. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer