From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9954 invoked by alias); 26 Mar 2002 18:14:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9902 invoked from network); 26 Mar 2002 18:14:00 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 26 Mar 2002 18:14:00 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16pvSF-0006n7-00; Tue, 26 Mar 2002 13:13:55 -0500 Date: Tue, 26 Mar 2002 10:14:00 -0000 From: Daniel Jacobowitz To: Michal Ludvig Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] x86-64 segment registers handling Message-ID: <20020326131355.A25917@nevyn.them.org> Mail-Followup-To: Michal Ludvig , gdb-patches@sources.redhat.com References: <3CA0AF53.8030609@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CA0AF53.8030609@suse.cz> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-03/txt/msg00499.txt.bz2 On Tue, Mar 26, 2002 at 06:26:43PM +0100, Michal Ludvig wrote: > Hi all, > this patch synces gdb with recent ABI changes in x86-64 kernel, which > added segment registers to user_regs_struct in corefile and ptrace() > call. Because it was hard to find all places which could depend on this > change I also did a cleanup. I joined most of registers information to > one structure at the beginning of x86-64-tdep.c to make it more readable > and maintainable and changed some "anonymous constants" (numbers) to > derivatives of #defines. > Can I commit? > > Index: ChangeLog > * x86-64-linux-nat.c (x86_64_regmap): Swapped > RBX <> RDX, added DS, ES, FD, GS Can you update gdbserver/linux-x86-64-low.c with these changes, please? > (x86_64_linux_dr_get_status), (supply_gregset), > (fill_gregset): Changed X86_64_NUM_GREGS to > x86_64_num_gregs > * x86-64-tdep.c (x86_64_register_raw_size_table): Delete > (x86_64_register_info_table): Add > (X86_64_NUM_REGS, X86_64_NUM_GREGS): Add > (x86_64_register_raw_size), > (x86_64_register_virtual_type), > (x86_64_register_name), > (_initialize_x86_64_tdep): Changed to reflect new > general x86_64_register_info_table. > (i386_gdbarch_init): gdbarch_register_bytes is now set > dynamicaly during initialization. Also, it appears that you changed the layout of GDB's register cache for x86-64. At this time that means you also changed the remote protocol. regformats/reg-x86-64.dat also needs to be updated. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer