From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23155 invoked by alias); 22 Mar 2002 18:52:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23106 invoked from network); 22 Mar 2002 18:52:21 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 22 Mar 2002 18:52:21 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16oU9D-0006d6-00; Fri, 22 Mar 2002 13:52:19 -0500 Date: Fri, 22 Mar 2002 10:52:00 -0000 From: Daniel Jacobowitz To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Select a particular mangling of a demangled symbol in lookup_block_symbol Message-ID: <20020322135219.B24693@nevyn.them.org> Mail-Followup-To: Elena Zannoni , gdb-patches@sources.redhat.com References: <20020214185503.A28610@nevyn.them.org> <15511.47485.557533.258275@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15511.47485.557533.258275@localhost.redhat.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-03/txt/msg00418.txt.bz2 On Tue, Mar 19, 2002 at 05:19:41PM -0500, Elena Zannoni wrote: > OK, approved. But I have my usual couple of questions: Committed to trunk only; I'll move it to the branch in a week or so if it doesn't break anything. > Was the corresponding testsuite patch sorted out? Looks like it > wasn't. Does this patch have any effect on the testsuite results w/o Nope. > the testsuite patch? I don't believe so. > In the above, should it be mangled_name = name or mangled_name = > modified_name? It would seem more uniform with the rest of the > function if we just used modified_name. Unless there is some problem > with case sensitivity, in which case, calling cplus_demangle with > modified_name seems wrong anyway. I.e. is it guaranteed that > case_sensitive_off is NOT in effect? Just out of curiosity What > would happen if the user sets the case sensitivity off? > Wouldn't it change _ZN3fooC1ERS_ to _zn3fooc1ers_ ? (of course the user > can always do a lot of things to screw himself up) As far as I'm concerned - if the user sets case sensitivity off while debugging C++, they deserve what they get. Mangling is not case-insensitive. In fact, in v3, cplus_demangle is absolutely guaranteed to fail (_z is not a legal prefix for a mangled name). Perhaps it would be better to call cplus_demangle with the original name. > I guess what I am really asking is when is lookup_symbol called with a > mangled name. I tried to do "break foo::foo", and I never saw it called > with a mangled name. find_methods will do it, in two places, at least if you're using stabs: sym_arr[i1] = lookup_symbol (phys_name, NULL, VAR_NAMESPACE, (int *) NULL, (struct symtab **) NULL); It shouldn't do this, of course, but that requires a lot of work that I haven't gotten to yet. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer