From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13508-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 23642 invoked by alias); 19 Mar 2002 19:27:51 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 23510 invoked from network); 19 Mar 2002 19:27:37 -0000
Received: from unknown (HELO nevyn.them.org) (128.2.145.6)
  by sources.redhat.com with SMTP; 19 Mar 2002 19:27:36 -0000
Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian))
	id 16nPGh-0004mi-00; Tue, 19 Mar 2002 14:27:35 -0500
Date: Tue, 19 Mar 2002 11:27:00 -0000
From: Daniel Jacobowitz <drow@mvista.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] Fix crashes on complex types
Message-ID: <20020319142735.A18376@nevyn.them.org>
Mail-Followup-To: Elena Zannoni <ezannoni@redhat.com>,
	gdb-patches@sources.redhat.com
References: <20020317132145.A5146@nevyn.them.org> <15511.36836.986235.25971@localhost.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <15511.36836.986235.25971@localhost.redhat.com>
User-Agent: Mutt/1.3.23i
X-SW-Source: 2002-03/txt/msg00360.txt.bz2

On Tue, Mar 19, 2002 at 02:22:12PM -0500, Elena Zannoni wrote:
> Daniel Jacobowitz writes:
>  > The complex type support has bitrotten a bit.  We used to set
>  > TYPE_TARGET_TYPE properly in all the places we would create such types,
>  > but a few more have crept in during the intervening years.  This patch
>  > just makes sure that field is valid, so that we can use it to print
>  > later.  This fixes PR gdb/422.
> 
> Looks good.

OK, I'll check it in later today.  Thanks!

>  > OK to commit?
>  > 
> 
> Any chance you can sneak in a testcase? Steal the gcc one?

Well, I don't know how.  I'll think about it.  The problem is that
complex types in C require either C99 or at least GCC; I'll see if I
can handle the testcase not compiling gracefully.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer