From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26333 invoked by alias); 14 Mar 2002 21:26:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26223 invoked from network); 14 Mar 2002 21:26:27 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 14 Mar 2002 21:26:27 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16lcjz-0002Vl-00; Thu, 14 Mar 2002 16:26:27 -0500 Date: Thu, 14 Mar 2002 13:26:00 -0000 From: Daniel Jacobowitz To: Jim Ingham Cc: gdb-patches@sources.redhat.com Subject: Re: add set cp-abi command Message-ID: <20020314162627.A9503@nevyn.them.org> Mail-Followup-To: Jim Ingham , gdb-patches@sources.redhat.com References: <20020313151130.B18842@nevyn.them.org> <6CC0BB4C-3790-11D6-8354-000393540DDC@apple.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6CC0BB4C-3790-11D6-8354-000393540DDC@apple.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-03/txt/msg00216.txt.bz2 On Thu, Mar 14, 2002 at 01:14:09PM -0800, Jim Ingham wrote: > Thanks... I am not sure it is really worth the effort. It is not > really something we want to encourage folks to do, after all, and in > time the issue will fade away... Very true. And by definition, there should really only be one ABI... if it comes up as a bug again somewhere else, we can look into this. > >>*************** > >>*** 103,109 **** > >>--- 106,164 ---- > >> int i; > >> for (i = 0; i < num_cp_abis; i++) > >> if (strcmp (cp_abis[i].shortname, short_name) == 0) > >>+ { > >> current_cp_abi = cp_abis[i]; > >> return 1; > >>+ } > >>+ > >>+ return 0; > >>+ } > > > >Indentation, of course. > > This is actually mailer mangling, it was right in the sources. $%#$#$$# > GUI mailers... Well, unless your mailer ate a "+" at the beginning of "return 1;", it wasn't right in the mail. That line is moving over. I'm sure you'll have it right when you commit it :) > >"currently selected C++ ABI", please. > > As you wish... Thanks. We may not have consistent grammar or spelling in our messages right now, but I'm still all over trying. > >>+ ui_out_field_string (uiout, "cp-abi", current_cp_abi.shortname); > >>+ ui_out_text (uiout, ".\n"); > >>+ } > >>+ > >>+ void > >>+ show_cp_abis_cmd (char *args, int from_tty) > >>+ { > >>+ int i; > >>+ ui_out_text (uiout, "The valid cplus abi's are:\n"); > > > >"C++ ABIs" (or ABI's? ABIs, I think, if there isn't a precedent) > > We actually checked Strunk & White, and as of the mid 30's, this should > be ABIs... "ABIs" looks like what I remember, too, so let's use that. > >I believe 'show cp-abi' should show the available ABIs. That's more in > >keeping with existing code. > > How would you find out the current ABI, then? Probably better is to > chuck the show abis, and let "set cp-abi" (with no arguments) perform > this function. This is the way "set language" works, so it has > precedent. I was sure that there was another command that used the > singular lists current, plural lists all, but I can't find it so maybe I > was just out of my mind... Shall we agree to mimic "set language", then? [For anyone following along: (gdb) set language The currently understood settings are: local or auto Automatic setting based on source file c Use the C language c++ Use the C++ language asm Use the Asm language chill Use the Chill language fortran Use the Fortran language java Use the Java language modula-2 Use the Modula-2 language pascal Use the Pascal language scheme Use the Scheme language (gdb) show language The current source language is "auto; currently c". ] -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer