From: Daniel Jacobowitz <drow@mvista.com>
To: "Peter.Schauer" <Peter.Schauer@regent.e-technik.tu-muenchen.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: your stabsread patch
Date: Wed, 27 Feb 2002 13:13:00 -0000 [thread overview]
Message-ID: <20020227161352.A13286@nevyn.them.org> (raw)
In-Reply-To: <200202272105.WAA08633@reisser.regent.e-technik.tu-muenchen.de>
I am going to stop trying to review patches when I don't have time to
look at them properly. You're quite correct. The situation is
somewhat suboptimal, as static methods will now 'always' be marked
stubbed in v3; but we'll return to that if/when GCC fixes debug output.
No further objection; I'm not sure I can approve C++-specific patches to
stabsread.c, though.
On Wed, Feb 27, 2002 at 10:05:26PM +0100, Peter.Schauer wrote:
> But my patch still sets the is_stub flag in this case, as the full physname
> (which is output by gcc3) does not match the main_fn_name.
> And together with the last gdb_mangle_name patch, check_stub_method will
> do the right thing with v3/stabs.
>
> Or am I missing something else ?
>
> > ...is not correct.
> >
> > Look at the debug output for a v3/stabs static method. Note that the
> > method is in fact stubbed! The physname is all there (which will be
> > handled in gdb_mangle_name after your last patch) and the return type
> > is there, but the arguments are missing.
> >
> > Feel free to argue that this is GCC's bug instead of ours. I think
> > both should be fixed.
> >
> > [I would have replied, but I have technical difficulties with my mail
> > right now.]
> >
> > --
> > Daniel Jacobowitz Carnegie Mellon University
> > MontaVista Software Debian GNU/Linux Developer
> >
> >
>
>
> --
> Peter Schauer pes@regent.e-technik.tu-muenchen.de
>
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2002-02-27 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-27 12:48 Daniel Jacobowitz
2002-02-27 13:05 ` Peter.Schauer
2002-02-27 13:13 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020227161352.A13286@nevyn.them.org \
--to=drow@mvista.com \
--cc=Peter.Schauer@regent.e-technik.tu-muenchen.de \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox