From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28064 invoked by alias); 23 Feb 2002 22:46:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26291 invoked from network); 23 Feb 2002 22:45:24 -0000 Received: from unknown (HELO duracef.shout.net) (204.253.184.12) by sources.redhat.com with SMTP; 23 Feb 2002 22:45:24 -0000 Received: (from mec@localhost) by duracef.shout.net (8.11.6/8.11.6) id g1NMjNE28966 for gdb-patches@sources.redhat.com; Sat, 23 Feb 2002 16:45:23 -0600 Date: Sat, 23 Feb 2002 14:46:00 -0000 From: Michael Elizabeth Chastain Message-Id: <200202232245.g1NMjNE28966@duracef.shout.net> To: gdb-patches@sources.redhat.com Subject: [RFA #2] gdb.threads/linux-dp.c: accommodate gcc 3.1 X-SW-Source: 2002-02/txt/msg00651.txt.bz2 This is RFA #2 for this patch. gcc HEAD has a new warning: warning: no return statement in function returning non-void Unfortunately this breaks code in gdb.threads/linux-dp.c: void * philosopher (void *data) { ... for (;;) { ... } } I consider this to be a bug in gcc HEAD, and I've filed PR gcc/5725. Meanwhile, I would like to change linux-dp.c so that it compiles. This way we are testing linux thread support, which is more useful than functioning as a test case for PR gcc/5725. I tested this patch on: [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=2.95.3 glibc=vendor goption=-gdwarf-2] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=2.95.3 glibc=vendor goption=-gstabs+] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.3 glibc=vendor goption=-gdwarf-2] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.3 glibc=vendor goption=-gstabs+] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4-20020215 glibc=vendor goption=-gdwarf-2] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4-20020215 glibc=vendor goption=-gstabs+] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4 glibc=vendor goption=-gdwarf-2] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4 glibc=vendor goption=-gstabs+] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=gcc-3_0-branch%20020222 glibc=vendor goption=-gdwarf-2] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=gcc-3_0-branch%20020222 glibc=vendor goption=-gstabs+] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=HEAD%20020222 glibc=vendor goption=-gdwarf-2] [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=HEAD%20020222 glibc=vendor goption=-gstabs+] References: Jason's message about the new warning: http://gcc.gnu.org/ml/gcc-patches/2002-02/msg00034.html My reply in the thread: http://gcc.gnu.org/ml/gcc-patches/2002-02/msg00704.html My gcc PR: http://gcc.gnu.org/cgi-bin/gnatsweb.pl?database=gcc&cmd=view&pr=5725 Okay to apply? Michael C === 2002-02-18 Michael Chastain * gdb.threads/linux-dp.c (philosopher): Add a return statement to placate gcc. Index: gdb/testsuite/gdb.threads/linux-dp.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.c,v retrieving revision 1.1.1.1 diff -c -3 -p -r1.1.1.1 linux-dp.c *** linux-dp.c 1999/10/19 02:46:48 1.1.1.1 --- linux-dp.c 2002/02/18 21:37:54 *************** philosopher (void *data) *** 153,158 **** --- 153,160 ---- pthread_mutex_unlock (&fork_mutex[(n + 1) % num_philosophers]); random_delay (); } + + return (void *) 0; } int