From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10064 invoked by alias); 20 Feb 2002 22:57:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9593 invoked from network); 20 Feb 2002 22:57:17 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 20 Feb 2002 22:57:17 -0000 Received: from drow by nevyn.them.org with local (Exim 3.34 #1 (Debian)) id 16dffj-0001fi-00; Wed, 20 Feb 2002 17:57:11 -0500 Date: Wed, 20 Feb 2002 14:57:00 -0000 From: Daniel Jacobowitz To: Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Kill a warning in linux-low.c Message-ID: <20020220175711.B6035@nevyn.them.org> Mail-Followup-To: Andreas Schwab , gdb-patches@sources.redhat.com References: <20020205171348.A11392@nevyn.them.org> <20020206102140.A17033@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020206102140.A17033@nevyn.them.org> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-02/txt/msg00569.txt.bz2 On Wed, Feb 06, 2002 at 10:21:40AM -0500, Daniel Jacobowitz wrote: > On Wed, Feb 06, 2002 at 01:25:46PM +0100, Andreas Schwab wrote: > > Daniel Jacobowitz writes: > > > > |> Waitpid's second argument is an (int *), not a (union wait *). Committed as > > |> obvious. > > > > Wouldn't it be better to make w an int instead? > > A little digging around in glibc tells me - yes, you're right. Union > wait is a BSD-ism. > > I'll fix this after the other three gdbserver patches get looked at. Fixed thusly; committed. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.2239 diff -u -p -r1.2239 ChangeLog --- ChangeLog 2002/02/20 22:51:40 1.2239 +++ ChangeLog 2002/02/20 22:56:30 @@ -1,5 +1,10 @@ 2002-02-20 Daniel Jacobowitz + * gdbserver/linux-low.c (mywait): Change argument to waitpid + to be an integer instead of a `union wait'. + +2002-02-20 Daniel Jacobowitz + * mips-linux-nat.c: Call the operating system GNU/Linux. * mips-linux-tdep.c: Likewise. * mips-tdep.c: Likewise. Index: gdbserver/linux-low.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v retrieving revision 1.7 diff -u -p -r1.7 linux-low.c --- linux-low.c 2002/02/14 06:21:22 1.7 +++ linux-low.c 2002/02/20 22:56:30 @@ -109,10 +109,10 @@ unsigned char mywait (char *status) { int pid; - union wait w; + int w; enable_async_io (); - pid = waitpid (inferior_pid, (int *)&w, 0); + pid = waitpid (inferior_pid, &w, 0); disable_async_io (); if (pid != inferior_pid) perror_with_name ("wait");