From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3481 invoked by alias); 17 Feb 2002 09:11:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3414 invoked from network); 17 Feb 2002 09:11:48 -0000 Received: from unknown (HELO is.elta.co.il) (199.203.121.2) by sources.redhat.com with SMTP; 17 Feb 2002 09:11:48 -0000 Received: (from eliz@localhost) by is.elta.co.il (8.9.3/8.8.8) id LAA24675; Sun, 17 Feb 2002 11:10:51 +0200 (IST) Date: Sun, 17 Feb 2002 01:11:00 -0000 From: Eli Zaretskii Message-Id: <200202170910.LAA24675@is.elta.co.il> To: tromey@redhat.com CC: fnasser@redhat.com, gdb-patches@sources.redhat.com In-reply-to: <87wuxgymst.fsf@creche.redhat.com> (message from Tom Tromey on 14 Feb 2002 10:51:14 -0700) Subject: Re: Patch: complete -vs- duplicates, take 2 Reply-to: Eli Zaretskii References: <87666g1nws.fsf@creche.redhat.com> <3C517C33.13B8A9D4@redhat.com> <2950-Fri25Jan2002204302+0200-eliz@is.elta.co.il> <87wuxgymst.fsf@creche.redhat.com> X-SW-Source: 2002-02/txt/msg00451.txt.bz2 > From: Tom Tromey > Date: 14 Feb 2002 10:51:14 -0700 > > So instead I've simply posted the entire functions in question. > Basically complete_line() was made by cut-and-paste from > line_completion_function(). No semantics were changed. Thanks. The separation of code from line_completion_function is okay with me. But I'm still missing something: how do the other changes (in cli-cmds.c) avoid removing duplicates twice? I see that you added duplicate removal to cli-cmds.c, but how does that prevent Readline from doing the same again? What am I missing?