From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-12779-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 5925 invoked by alias); 14 Feb 2002 05:32:10 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5821 invoked from network); 14 Feb 2002 05:32:02 -0000
Received: from unknown (HELO nevyn.them.org) (128.2.145.6)
  by sources.redhat.com with SMTP; 14 Feb 2002 05:32:02 -0000
Received: from drow by nevyn.them.org with local (Exim 3.34 #1 (Debian))
	id 16bEUw-0004BR-00; Thu, 14 Feb 2002 00:31:58 -0500
Date: Wed, 13 Feb 2002 21:32:00 -0000
From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] gdbserver 1/3 - top level config
Message-ID: <20020214003158.A3061@nevyn.them.org>
Mail-Followup-To: Andrew Cagney <ac131313@cygnus.com>,
	gdb-patches@sources.redhat.com
References: <20020205174549.A13231@nevyn.them.org> <3C6B3B1D.5060704@cygnus.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3C6B3B1D.5060704@cygnus.com>
User-Agent: Mutt/1.3.23i
X-SW-Source: 2002-02/txt/msg00394.txt.bz2

On Wed, Feb 13, 2002 at 11:20:45PM -0500, Andrew Cagney wrote:
> 
> >-# these really aren't orthogonal true/false values of the same condition,
> >-# but shells are slow enough that I like to reuse the test conditions
> >-# whenever possible
> 
> Yes, the comment was silly.
> 
> However a comment indicating that the NATIVE info is picked up from the 
> HOST (.mh) file because there is no NATIVE (.mn) file would be useful.

Is this about what you were looking for?
# We pick this up from the host configuration file (.mh) because we
# do not have a native configuration Makefile fragment.

> > if test "${target}" = "${host}"; then
> > nativefile=`sed -n '
> > s/NAT_FILE[ 	]*=[ 	]*\([^ 	]*\)/\1/p
> > ' ${host_makefile_frag}`
> >-# else
> >-# GDBserver is only useful in a "native" environment
> >-# configdirs=`echo $configdirs | sed 's/gdbserver//'`
> > fi
> > changequote([,])
> > 
> >@@ -1277,10 +1271,16 @@
> >     *)  AC_MSG_ERROR("GDB: Unknown GDB_MULTI_ARCH value ${GDB_MULTI_ARCH}");;
> > esac
> > 
> >-
> > SUBDIRS="doc testsuite nlm"
> > if test "${enable_multi_ice}" = "yes"; then
> >   SUBDIRS="${SUBDIRS} multi-ice"
> >+fi
> 
> >+if test x"${target}" = x"${host}"; then
> >+    if test x"${build_gdbserver}" = xyes ; then
> >+	configdirs="${configdirs} gdbserver"
> >+	SUBDIRS="${SUBDIRS} gdbserver"
> >+    fi
> 
> v.good move.  make it clear that the condition is separate/independant. 
>  Can I again suggest a comment explaining why.  Is it possible to print 
> an info message?

Sure.  Committed with those changes.  The tree will not build for an
hour or so while I commit and check the other parts.  I'll go through
and do NEWS entries in the next day or two, I promise.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer