Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: kettenis@chello.nl
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Fix PR gdb/290
Date: Sat, 09 Feb 2002 09:27:00 -0000	[thread overview]
Message-ID: <20020209172736.38606.qmail@elgar.kettenis.dyndns.org> (raw)

Checked in as obvious.  Wonder why GCC didn't warn about this.  Should
we add some more -Wxxx flags?

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* doublest.c (store_typed_floating): Don't try to return a value.
	Fixes PR gdb/290.

Index: doublest.c
===================================================================
RCS file: /cvs/src/src/gdb/doublest.c,v
retrieving revision 1.8
diff -u -p -r1.8 doublest.c
--- doublest.c 2002/01/22 19:57:40 1.8
+++ doublest.c 2002/02/09 17:24:44
@@ -732,9 +732,9 @@ store_typed_floating (void *addr, const 
   memset (addr, 0, TYPE_LENGTH (type));
 
   if (TYPE_FLOATFORMAT (type) == NULL)
-    return store_floating (addr, TYPE_LENGTH (type), val);
-
-  floatformat_from_doublest (TYPE_FLOATFORMAT (type), &val, addr);
+    store_floating (addr, TYPE_LENGTH (type), val);
+  else
+    floatformat_from_doublest (TYPE_FLOATFORMAT (type), &val, addr);
 }
 
 /* Convert a floating-point number of type FROM_TYPE from a


             reply	other threads:[~2002-02-09 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-09  9:27 kettenis [this message]
2002-02-09 11:19 ` Andrew Cagney
2002-02-09 11:37   ` Joe Buck
2002-02-09 11:51     ` Andrew Cagney
2002-02-09 12:18     ` Andreas Schwab
2002-02-09 17:39       ` Joe Buck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020209172736.38606.qmail@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox