From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20993 invoked by alias); 9 Feb 2002 22:14:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20922 invoked from network); 9 Feb 2002 22:14:52 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 9 Feb 2002 22:14:52 -0000 Received: from drow by nevyn.them.org with local (Exim 3.34 #1 (Debian)) id 16Zflj-0007XW-00; Sat, 09 Feb 2002 17:14:51 -0500 Date: Sat, 09 Feb 2002 14:14:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite] Allow __libc_start_main above main in annota1.exp Message-ID: <20020209171451.A28967@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sources.redhat.com References: <20020109190628.A18672@nevyn.them.org> <20020130005704.B28963@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i X-SW-Source: 2002-02/txt/msg00288.txt.bz2 I assume so. But that patch went in, and I'd rather leave it in at least until we have a policy about what not to display that goes across all targets. On Sat, Feb 09, 2002 at 11:21:24AM -0500, Jim Blandy wrote: > > If you apply my FRAME_CHAIN_VALID patch, doesn't that simply eliminate > these failures altogether, since __libc_start_main doesn't appear in > the backtrace? > > Daniel Jacobowitz writes: > > > On Wed, Jan 09, 2002 at 07:06:28PM -0500, Daniel Jacobowitz wrote: > > > >From the "annoying testsuite failures cleanup" department - if anyone has a > > > bright idea on how to write annota tests in a more readable, less > > > long-single-line fashion, I'd love to hear it. This fixes the test on all > > > my compiler/debug combinations, i386-linux. OK to commit? > > > > Anyone? > > > > > 2002-01-09 Daniel Jacobowitz > > > > > > * gdb.base/annota1.exp (backtrace from shlibrary): Fix spelling. > > > Allow a start function above main. > > > > > > Index: annota1.exp > > > =================================================================== > > > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v > > > retrieving revision 1.7 > > > diff -u -p -r1.7 annota1.exp > > > --- annota1.exp 2001/12/20 16:52:07 1.7 > > > +++ annota1.exp 2002/01/09 23:53:35 > > > @@ -247,8 +247,8 @@ gdb_expect { > > > # > > > send_gdb "backtrace\n" > > > gdb_expect { > > > - -re "\r\n\032\032post-prompt\r\n\r\n\032\032frame-begin 0 $hex\r\n.0 \r\n(\032\032frame-address\r\n$hex\r\n\032\032frame-address-end\r\n in \r\n)*\032\032frame-function-name\r\nprintf\r\n\032\032frame-args\r\n \\(.*frame-end\r\n\r\n\032\032frame-begin 1 $hex\r\n.1 \r\n\032\032frame-address\r\n$hex\r\n\032\032frame-address-end\r\n in \r\n\032\032frame-function-name\r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n${srcdir}/${subdir}/${srcfile}\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032frame-end\r\n$gdb_prompt$" \ > > > - { pass "bactrace from shlibrary" } > > > + -re "\r\n\032\032post-prompt\r\n\r\n\032\032frame-begin 0 $hex\r\n.0 \r\n(\032\032frame-address\r\n$hex\r\n\032\032frame-address-end\r\n in \r\n)*\032\032frame-function-name\r\nprintf\r\n\032\032frame-args\r\n \\(.*frame-end\r\n\r\n\032\032frame-begin 1 $hex\r\n.1 \r\n\032\032frame-address\r\n$hex\r\n\032\032frame-address-end\r\n in \r\n\032\032frame-function-name\r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n${srcdir}/${subdir}/${srcfile}\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n.*\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032frame-end\r\n(\r\n\032\032frame-begin .*\r\n\r\n\032\032frame-end\r\n)*$gdb_prompt$" \ > > > + { pass "backtrace from shlibrary" } > > > -re ".*$gdb_prompt$" { fail "backtrace from shlibrary" } > > > timeout { fail "backtrace from shlibrary (timeout)" } > > > } > > > > > > > -- > > Daniel Jacobowitz Carnegie Mellon University > > MontaVista Software Debian GNU/Linux Developer > -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer