From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9010 invoked by alias); 4 Feb 2002 15:27:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8920 invoked from network); 4 Feb 2002 15:27:20 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 4 Feb 2002 15:27:20 -0000 Received: from drow by nevyn.them.org with local (Exim 3.34 #1 (Debian)) id 16Xl1i-0001Xz-00; Mon, 04 Feb 2002 10:27:26 -0500 Date: Mon, 04 Feb 2002 07:27:00 -0000 From: Daniel Jacobowitz To: Richard.Earnshaw@arm.com Cc: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [patch] Zap remaining calls to error_begin() Message-ID: <20020204102726.A4464@nevyn.them.org> Mail-Followup-To: Richard.Earnshaw@arm.com, Andrew Cagney , gdb-patches@sources.redhat.com References: <3C5B605B.6030007@cygnus.com> <200202041121.LAA09467@cam-mail2.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200202041121.LAA09467@cam-mail2.cambridge.arm.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-02/txt/msg00073.txt.bz2 On Mon, Feb 04, 2002 at 11:21:54AM +0000, Richard Earnshaw wrote: > > > 2002-01-31 Andrew Cagney > > > > > > * utils.c (error_begin): Make static. > > > * defs.h (error_begin): Delete declaration. > > > > > > * linespec.c (cplusplus_error): Replace cplusplus_hint. > > > (decode_line_1): Use cplusplus_error instead of error_begin, > > > cplusplus_hint and return_to_top_level. > > > * coffread.c (coff_symfile_read): Use error instead of error_begin > > > and return_to_top_level. > > > * infrun.c (default_skip_permanent_breakpoint): Ditto. > > > > > > > I've checked this in. > > I'm not sure if this is related, but I'm now seeing a regression in the > testsuite for an arm-netbsd target: > > FAIL: gdb.c++/annota2.exp: annotate-quit > > Since the missing text from the log is: > > - error-begin > - Quit > - > - quit > > I think the smoking gun must be pointing somewhere in this direction. Try running the test a couple dozen times, and see what happens, please? This test fails spuriously, or perhaps passes spuriously. I think there's something actually wrong with GDB's signal handling in relation to the way expect invokes us. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer