From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31298 invoked by alias); 31 Jan 2002 05:04:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31253 invoked from network); 31 Jan 2002 05:04:00 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 31 Jan 2002 05:04:00 -0000 Received: from drow by nevyn.them.org with local (Exim 3.34 #1 (Debian)) id 16W9OK-0005wQ-00 for ; Thu, 31 Jan 2002 00:04:08 -0500 Date: Wed, 30 Jan 2002 21:04:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix for searching for data symbols Message-ID: <20020131000408.C22536@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20020119123318.A1378@nevyn.them.org> <15448.33040.785604.720796@localhost.cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15448.33040.785604.720796@localhost.cygnus.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-01/txt/msg00802.txt.bz2 On Wed, Jan 30, 2002 at 06:26:08PM -0500, Elena Zannoni wrote: > Daniel Jacobowitz writes: > > This patch fixes the problem I described in: > > http://sources.redhat.com/ml/gdb/2002-01/msg00223.html > > > > Basically, since we use the bounds of the text segment to search for symbols > > in find_pc_*, don't let them return a bogus answer for a symbol we know is > > off in data land. > > > > OK to commit, or does anyone prefer a different approach to this? > > > > I think it's fine. Just could you add comments with an explanation of > the odd case that you described in the mail above? Committed with comments, thanks! -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer