Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Fred Fish <fnf@fred.ninemoons.com>
To: gdb-patches@sources.redhat.com
Cc: fnf@redhat.com
Subject: [RFA] Patch for THUMB skip_prologue code
Date: Fri, 18 Jan 2002 15:49:00 -0000	[thread overview]
Message-ID: <200201182349.g0INnLU01677@fred.ninemoons.com> (raw)

The current THUMB prologue skipping code does not stop until
it reaches either the end of the function, or an address that
is the function start address plus 40.  This patch fixes it.
The gdb testsuite results for thumb code after applying this
patch have the following diff:

  10694c10694
  < FAIL: gdb.base/nodebug.exp: running to middle in runto
  ---
  > PASS: gdb.base/nodebug.exp: backtrace from middle in nodebug.exp
  15907,15908c15907,15908
  < # of expected passes        7469
  < # of unexpected failures    104
  ---
  > # of expected passes        7470
  > # of unexpected failures    103

-Fred

============================================================

2002-01-18  Fred Fish  <fnf@redhat.com>

	* arm-tdep.c (thumb_skip_prologue): Quit scanning prologue
	when we have found all instructions we are looking for.

Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.26
diff -u -p -r1.26 arm-tdep.c
--- arm-tdep.c	2002/01/09 18:07:48	1.26
+++ arm-tdep.c	2002/01/18 23:26:14
@@ -376,6 +376,10 @@ thumb_skip_prologue (CORE_ADDR pc, CORE_
 	{
 	  findmask |= 2;  /* setting of r7 found */
 	}
+      else if (findmask == (4+2+1))
+	{
+	  break;	/* We have found one of each type of prologue instruction */
+	}
       else
 	continue;	/* something in the prolog that we don't care about or some
 	  		   instruction from outside the prolog scheduled here for optimization */


             reply	other threads:[~2002-01-18 23:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-18 15:49 Fred Fish [this message]
2002-01-18 16:33 ` Michael Snyder
2002-01-20 16:33 ` Andrew Cagney
2002-01-21  8:35 ` Fernando Nasser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200201182349.g0INnLU01677@fred.ninemoons.com \
    --to=fnf@fred.ninemoons.com \
    --cc=fnf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox