From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7506 invoked by alias); 17 Jan 2002 15:14:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7418 invoked from network); 17 Jan 2002 15:14:47 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 17 Jan 2002 15:14:47 -0000 Received: from drow by nevyn.them.org with local (Exim 3.33 #1 (Debian)) id 16REFj-00087b-00 for ; Thu, 17 Jan 2002 10:14:55 -0500 Date: Thu, 17 Jan 2002 07:14:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: PATCH to stabsread.c:read_member_functions Message-ID: <20020117101455.A31202@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i X-SW-Source: 2002-01/txt/msg00479.txt.bz2 On Thu, Jan 17, 2002 at 03:06:49PM +0000, Jason Merrill wrote: > This patch fixes gdb.c++/classes.exp:ptype Static when used with gcc 3.x > and stabs output. The code in question was never correct, just a likely > guess; in particular, it got things wrong even with the v2 output for > Static::ii, where the plain function name ("ii") was the same as the > mangled form of the argument list (int, int == "ii"). For v3, we don't try > to do minimal output, so it will always guess wrong. > > OK? Should I just remove the bad code rather than comment it out? > > 2002-01-17 Jason Merrill > > * stabsread.c (read_member_functions): Never guess that the given > physname for a static member function is a stub. > Not OK, I think. v2 -does- do minimal output, right? We are not dropping v2 support. I've been meaning to fix this since I added the test. The proper fix might be to either: - know when to expect minimal output. Does v2 ever not do it? What about other C++ compilers? - Check if it is a valid mangled name. Will that work - can the argument list ever be a valid mangled name in its own right? -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer