From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23333 invoked by alias); 13 Jan 2002 15:28:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23296 invoked from network); 13 Jan 2002 15:28:30 -0000 Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3) by sources.redhat.com with SMTP; 13 Jan 2002 15:28:30 -0000 Received: by fw-cam.cambridge.arm.com; id PAA26075; Sun, 13 Jan 2002 15:28:29 GMT Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5) id xma025961; Sun, 13 Jan 02 15:28:06 GMT Received: from cam-mail2.cambridge.arm.com (localhost [127.0.0.1]) by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id PAA17418; Sun, 13 Jan 2002 15:28:06 GMT Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18]) by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id PAA21457; Sun, 13 Jan 2002 15:28:05 GMT Message-Id: <200201131528.PAA21457@cam-mail2.cambridge.arm.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Kevin Buettner cc: Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com Reply-To: Richard.Earnshaw@arm.com Organization: ARM Ltd. X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd) X-Fax: +44 1223 400410 X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ. X-Url: http://www.arm.com/ Subject: Re: [PATCH] ARM: Eliminate EXTRA_FRAME_INFO & FRAME_FIND_SAVED_REGS In-reply-to: Your message of "Sat, 12 Jan 2002 10:46:26 MST." <1020112174626.ZM14727@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 13 Jan 2002 07:28:00 -0000 From: Richard Earnshaw X-SW-Source: 2002-01/txt/msg00340.txt.bz2 > On Jan 12, 11:50am, Richard Earnshaw wrote: > > > This patch eliminates the deprecated macros EXTRA_FRAME_INFO & > > FRAME_FIND_SAVED_REGS from the arm target support files and replaces them > > with the new methods for doing this. > > I submitted a patch to do this last month. Unfortunately, the ARM > maintainers have not had a chance to review it yet. > > See http://sources.redhat.com/ml/gdb-patches/2001-12/msg00397.html > > Kevin Argh! Sorry Kevin, I'd missed that patch, and it isn't in the list of posts I'd hung on to (actually, I'd already left for Xmas by that point, so it was probably part of the 5000 or so emails I had to skim when I got back in January ;-(. Hmm, it seems substantially the same as mine, but with a couple of minor differences. 1) You don't seem to initialize the pointer fields in the static frame structure "prologue_cache". 2) Similarly you don't seem to be allocating the saved_regs for the caller_fi frame (arm_frame_chain). You do, however, allocate the extra_info. 3) You have a cleanup for the extra_info allocated above, which I hadn't thought about. I think one is also needed for the saved_regs. R.