From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11783-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 22822 invoked by alias); 10 Jan 2002 15:33:35 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 22794 invoked from network); 10 Jan 2002 15:33:33 -0000
Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3)
  by sources.redhat.com with SMTP; 10 Jan 2002 15:33:33 -0000
Received: by fw-cam.cambridge.arm.com; id PAA25632; Thu, 10 Jan 2002 15:33:32 GMT
Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5)
	id xma025412; Thu, 10 Jan 02 15:33:20 GMT
Received: from cam-mail2.cambridge.arm.com (localhost [127.0.0.1])
	by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id PAA08184;
	Thu, 10 Jan 2002 15:33:19 GMT
Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18])
	by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id PAA13419;
	Thu, 10 Jan 2002 15:33:18 GMT
Message-Id: <200201101533.PAA13419@cam-mail2.cambridge.arm.com>
X-Mailer: exmh version 2.0.2 2/24/98
To: fnf@redhat.com
cc: gdb-patches@sources.redhat.com, Richard.Earnshaw@arm.com
Reply-To: Richard.Earnshaw@arm.com
Organization: ARM Ltd.
X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd)
X-Fax: +44 1223 400410
X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ.
X-Url: http://www.arm.com/
Subject: Re: RFC: ARM simulator coredump 
In-reply-to: Your message of "Wed, 09 Jan 2002 15:58:47 MST."
             <200201092258.g09MwlU26601@fred.ninemoons.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 10 Jan 2002 07:33:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
X-SW-Source: 2002-01/txt/msg00228.txt.bz2

> +	  int ok = state->CPRead[14] (state, 0, &cp14r0);

As a coding nit, I can't say I'm madly keen on a variable that's called 
"ok".  At any point other than its assignment, it isn't going to be very 
clear what is "ok".  This variable is used over more than 50 lines of code 
which, at least for me, means that I won't be able to see the assignment 
at the same time as it's final use.

R.