From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14384 invoked by alias); 10 Jan 2002 19:57:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14343 invoked from network); 10 Jan 2002 19:57:16 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 10 Jan 2002 19:57:16 -0000 Received: from drow by nevyn.them.org with local (Exim 3.33 #1 (Debian)) id 16OlKv-0002km-00 for ; Thu, 10 Jan 2002 14:58:05 -0500 Date: Thu, 10 Jan 2002 11:57:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: PATCH to dwarf2read.c:decode_locdesc Message-ID: <20020110145805.C10383@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i X-SW-Source: 2002-01/txt/msg00247.txt.bz2 On Thu, Jan 10, 2002 at 12:26:33PM +0000, Jason Merrill wrote: > I noticed that even with Daniel's recent C++ improvements (thanks!), vbase > handling was still broken with dwarf2 because dwarf2read.c still didn't > grok the complex location expression gcc now emits. As it happens, by a > fluke simply adding support for the missing opcodes causes decode_locdesc > to produce the answer gdb wants. The dwarf2 output expects the stack to > start with the address of the object and produce the address of the base, > whereas in the current gdb the stack starts with 0 and produces the > negation of whatever constant is provided, which matches the stabs output. > > Of course, gdb tries to complain about the derefs twice in the process, but > is currently muffled. > > So, it's not a complete solution, but it's entirely correct and fixes > gdb.c++/inherit.exp. > > OK to commit? [I can't approve but] thanks! This has been stewing on my TODO list while I fixed other things in the type code. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer