From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5824 invoked by alias); 9 Jan 2002 15:54:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5780 invoked from network); 9 Jan 2002 15:54:14 -0000 Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3) by sources.redhat.com with SMTP; 9 Jan 2002 15:54:14 -0000 Received: by fw-cam.cambridge.arm.com; id PAA05279; Wed, 9 Jan 2002 15:54:12 GMT Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5) id xma004139; Wed, 9 Jan 02 15:53:21 GMT Received: from cam-mail2.cambridge.arm.com (localhost [127.0.0.1]) by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id PAA03955; Wed, 9 Jan 2002 15:53:20 GMT Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18]) by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id PAA04585; Wed, 9 Jan 2002 15:53:19 GMT Message-Id: <200201091553.PAA04585@cam-mail2.cambridge.arm.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Kevin Buettner cc: Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com Reply-To: Richard.Earnshaw@arm.com Organization: ARM Ltd. X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd) X-Fax: +44 1223 400410 X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ. X-Url: http://www.arm.com/ Subject: Re: [PATCH] fix inferior_pid argument for arm-netbsd In-reply-to: Your message of "Wed, 09 Jan 2002 08:39:50 MST." <1020109153950.ZM31326@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed ; boundary="==_Exmh_7171141760" Date: Wed, 09 Jan 2002 07:54:00 -0000 From: Richard Earnshaw X-SW-Source: 2002-01/txt/msg00173.txt.bz2 This is a multipart MIME message. --==_Exmh_7171141760 Content-Type: text/plain; charset=us-ascii Content-length: 480 > On Jan 9, 1:38pm, Richard Earnshaw wrote: > > > * armnbsd-nat.c (fetch_inferior_registers): Change inferior_pid -> > > inferior_ptid.pid. > > Please don't do it this way. Use the accessor functions instead. I've > looked over your patch, and in each case, you can simply use > > ptid_get_pid (inferior_ptid) > Ah! I wasn't aware of the accessor functions. In fact, most targets are using the macro GETPID (from defs.h). I've fixed the code to use that. R. --==_Exmh_7171141760 Content-Type: text/x-patch ; name="pid.patch"; charset=us-ascii Content-Description: pid.patch Content-Disposition: attachment; filename="pid.patch" Content-length: 2214 Index: armnbsd-nat.c =================================================================== RCS file: /cvs/src/src/gdb/armnbsd-nat.c,v retrieving revision 1.1 diff -p -r1.1 armnbsd-nat.c *** armnbsd-nat.c 2001/12/17 21:14:10 1.1 --- armnbsd-nat.c 2002/01/09 15:51:15 *************** fetch_inferior_registers (regno) *** 34,46 **** struct reg inferior_registers; struct fpreg inferior_fpregisters; ! ptrace (PT_GETREGS, inferior_pid, (PTRACE_ARG3_TYPE) &inferior_registers, 0); memcpy (®isters[REGISTER_BYTE (0)], &inferior_registers, 16 * sizeof (unsigned int)); memcpy (®isters[REGISTER_BYTE (PS_REGNUM)], &inferior_registers.r_cpsr, sizeof (unsigned int)); ! ptrace (PT_GETFPREGS, inferior_pid, (PTRACE_ARG3_TYPE) &inferior_fpregisters, ! 0); memcpy (®isters[REGISTER_BYTE (F0_REGNUM)], &inferior_fpregisters.fpr[0], 8 * sizeof (fp_reg_t)); memcpy (®isters[REGISTER_BYTE (FPS_REGNUM)], --- 34,47 ---- struct reg inferior_registers; struct fpreg inferior_fpregisters; ! ptrace (PT_GETREGS, PIDGET (inferior_ptid), ! (PTRACE_ARG3_TYPE) &inferior_registers, 0); memcpy (®isters[REGISTER_BYTE (0)], &inferior_registers, 16 * sizeof (unsigned int)); memcpy (®isters[REGISTER_BYTE (PS_REGNUM)], &inferior_registers.r_cpsr, sizeof (unsigned int)); ! ptrace (PT_GETFPREGS, PIDGET (inferior_ptid), ! (PTRACE_ARG3_TYPE) &inferior_fpregisters, 0); memcpy (®isters[REGISTER_BYTE (F0_REGNUM)], &inferior_fpregisters.fpr[0], 8 * sizeof (fp_reg_t)); memcpy (®isters[REGISTER_BYTE (FPS_REGNUM)], *************** store_inferior_registers (regno) *** 58,64 **** 16 * sizeof (unsigned int)); memcpy (&inferior_registers.r_cpsr, ®isters[REGISTER_BYTE (PS_REGNUM)], sizeof (unsigned int)); ! ptrace (PT_SETREGS, inferior_pid, (PTRACE_ARG3_TYPE) &inferior_registers, 0); /* XXX Set FP regs. */ } --- 59,66 ---- 16 * sizeof (unsigned int)); memcpy (&inferior_registers.r_cpsr, ®isters[REGISTER_BYTE (PS_REGNUM)], sizeof (unsigned int)); ! ptrace (PT_SETREGS, PIDGET (inferior_ptid), ! (PTRACE_ARG3_TYPE) &inferior_registers, 0); /* XXX Set FP regs. */ } --==_Exmh_7171141760--