From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com, msnyder@redhat.com
Subject: linux-proc readlink patch
Date: Wed, 09 Jan 2002 12:15:00 -0000 [thread overview]
Message-ID: <20020109151622.A842@nevyn.them.org> (raw)
This patch:
2002-01-08 Michael Snyder <msnyder@redhat.com>
* linux-proc.c (child_pid_to_exec_file): Use readlink to get the
real name of the executable, rather than the /proc name.
(which I never saw posted on gdb-patches; was that an artifact of the email
breakage yesterday?)
seems to have at least one problem.
(1) It introduces a memory leak, if I understand the semantics of cleanups
correctly. make_cleanup's cleanups will only be called (according to the
comment in utils.c) after a failed command.
(2) It is not, IIRC, always correct in the case of chroots. Handling for
this has changed across Linux versions several times. On 2.2 it seems to be
correct (to my surprise, actually), but I believe it is not on 2.0. Do we
care? Probably not, as 2.0 is now -very- old.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
next reply other threads:[~2002-01-09 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 12:15 Daniel Jacobowitz [this message]
2002-01-09 12:51 ` Andrew Cagney
2002-01-09 14:24 ` Michael Snyder
2002-01-09 15:09 ` Daniel Jacobowitz
2002-01-09 15:40 ` Kevin Buettner
2002-01-09 15:45 ` Daniel Jacobowitz
2002-01-10 7:56 Michael Elizabeth Chastain
2002-01-10 9:32 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020109151622.A842@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox