From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15528 invoked by alias); 5 Jan 2002 02:52:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15487 invoked from network); 5 Jan 2002 02:52:02 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 5 Jan 2002 02:52:02 -0000 Received: from reddwarf.cygnus.com (reddwarf.cygnus.com [205.180.231.12]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id SAA09383 for ; Fri, 4 Jan 2002 18:52:01 -0800 (PST) Received: (from msnyder@localhost) by reddwarf.cygnus.com (8.11.2/8.11.2) id g052lHU16418 for gdb-patches@sources.redhat.com; Fri, 4 Jan 2002 18:47:17 -0800 Date: Fri, 04 Jan 2002 18:52:00 -0000 From: Michael Snyder Message-Id: <200201050247.g052lHU16418@reddwarf.cygnus.com> To: gdb-patches@sources.redhat.com Subject: [RFA] "Help" command and completion X-SW-Source: 2002-01/txt/msg00058.txt.bz2 Hmmm... currently the help command uses the default completer, which completes on symbols. That's definitely not right. Ideally, we want to complete on commands or something, but substituting the noop complete would definitely be better than completing on symbols. OK to check in? 2002-01-04 Michael Snyder * cli/cli-cmds.c (init_cli_cmds): The "help" command should not use the default completer. Substitute noop_completer, although a command completer would be better. Index: cli/cli-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v retrieving revision 1.10 diff -c -3 -p -r1.10 cli-cmds.c *** cli-cmds.c 2001/09/01 21:38:05 1.10 --- cli-cmds.c 2002/01/05 02:47:58 *************** when gdb is started.", &cmdlist); *** 668,674 **** c->completer = filename_completer; add_com ("quit", class_support, quit_command, "Exit gdb."); ! add_com ("help", class_support, help_command, "Print list of commands."); add_com_alias ("q", "quit", class_support, 1); add_com_alias ("h", "help", class_support, 1); --- 668,676 ---- c->completer = filename_completer; add_com ("quit", class_support, quit_command, "Exit gdb."); ! c = add_com ("help", class_support, help_command, ! "Print list of commands."); ! c->completer = noop_completer; add_com_alias ("q", "quit", class_support, 1); add_com_alias ("h", "help", class_support, 1);