From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17867 invoked by alias); 23 Dec 2001 21:12:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17832 invoked from network); 23 Dec 2001 21:12:17 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 23 Dec 2001 21:12:17 -0000 Received: from drow by nevyn.them.org with local (Exim 3.33 #1 (Debian)) id 16IFuP-0001kZ-00; Sun, 23 Dec 2001 16:11:49 -0500 Date: Sun, 23 Dec 2001 13:12:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFC] Add back the 'info proc mappings' command. Message-ID: <20011223161149.A6649@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sources.redhat.com References: <200112212259.OAA18720@cleaver.cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112212259.OAA18720@cleaver.cygnus.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2001-12/txt/msg00573.txt.bz2 On Fri, Dec 21, 2001 at 02:59:53PM -0800, Michael Snyder wrote: > > This adds back a sub-command ('mappings') of the "info proc" > command, which was lost a couple years ago when procfs.c was > rewritten. There are a bunch of other sub-commands that could > also be added back in -- I just happened to need this one. > > I'll wait a week for objections before I check it in. > > 2001-12-21 Michael Snyder > > * procfs.c (info_proc_cmd): Add the 'mappings' sub-command that > was dropped a few years ago, when procfs.c was rewritten. > (info_proc_mappings): New function, implent 'info proc mappings'. > (mappingflags): New function. > (_initialize_procfs): Document new option to 'info proc' command. > > Index: procfs.c > =================================================================== > RCS file: /cvs/src/src/gdb/procfs.c,v > retrieving revision 1.32 > diff -c -3 -p -r1.32 procfs.c > *** procfs.c 2001/07/07 21:55:28 1.32 > --- procfs.c 2001/12/21 22:57:30 > *************** proc_set_watchpoint (procinfo *pi, CORE_ > *** 2879,2889 **** > * or zero. > */ > > - /* FIXME: it's probably a waste to cache this FD. > - It doesn't get called that often... and if I open it > - every time, I don't need to lseek it. */ > int > ! proc_iterate_over_mappings (int (*func) (int, CORE_ADDR)) > { > struct prmap *map; > procinfo *pi; > --- 2879,2886 ---- > * or zero. > */ > > int > ! proc_iterate_over_mappings (int (*func) (int, CORE_ADDR) > { > struct prmap *map; > procinfo *pi; That's a typo, I think - you deleted a parenthesis. Did this compile? Looks fine to me otherwise, FWIW. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer