From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11222 invoked by alias); 13 Dec 2001 15:11:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11173 invoked from network); 13 Dec 2001 15:11:06 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 13 Dec 2001 15:11:06 -0000 Received: from cygbert.vinschen.de (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id HAA21932 for ; Thu, 13 Dec 2001 07:11:01 -0800 (PST) Received: (from corinna@localhost) by cygbert.vinschen.de (8.9.3/8.9.3/Linux sendmail 8.9.3) id QAA19147 for gdb-patches@sources.redhat.com; Thu, 13 Dec 2001 16:10:29 +0100 Date: Thu, 13 Dec 2001 07:11:00 -0000 From: Corinna Vinschen To: gdb-patches Subject: Re: [RFA]: port to Sanyo XStormy16 CPU Message-ID: <20011213161029.B740@cygbert.vinschen.de> Reply-To: gdb-patches Mail-Followup-To: gdb-patches References: <20011210121151.H740@cygbert.vinschen.de> <3C1693C3.9000106@cygnus.com> <20011213144437.A18705@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011213144437.A18705@cygbert.vinschen.de>; from vinschen@redhat.com on Thu, Dec 13, 2001 at 02:44:37PM +0100 X-SW-Source: 2001-12/txt/msg00344.txt.bz2 On Thu, Dec 13, 2001 at 02:44:37PM +0100, Corinna Vinschen wrote: > On Tue, Dec 11, 2001 at 03:16:19PM -0800, Andrew Cagney wrote: > > > Corinna > > > > > > gdb ChangeLog: > > > > > > 2001-12-10 Corinna Vinschen > > > > > > * Makefile.in: Add support for xstormy16. > > > * configure.tgt: Ditto. > > > * xstormy16-tdep.c: New file. > > > * config/xstormy16/xstormy16.mt: New file. > > > > > > gdb/testsuite ChangeLog: > > > > > > Yes. Your code is fine. The comments are very much appreciated. > > > > Just the usual style things: can I suggest making macro's like > > TYPE_IS_SCALAR functions; can you please put the .c files through > > gdb/gdb_indent.sh so it matches GDB's indentation style. > > I've rearranged the macro TYPE_IS_SCALAR() to be a function called > xstormy16_type_is_scalar and I ran gdb_indent.sh on xstormy16-tdep.c. > > Thanks for the approval, I've applied everything. Uh, careful question: Do I have to add myself as XStormy16 maintainer to the MAINTAINERS file now? Corinna