From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16078 invoked by alias); 9 Dec 2001 18:21:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15943 invoked from network); 9 Dec 2001 18:20:30 -0000 Received: from unknown (HELO fishpond.ninemoons.com) (64.232.230.104) by sources.redhat.com with SMTP; 9 Dec 2001 18:20:30 -0000 Received: (from fnf@localhost) by fishpond.ninemoons.com (8.11.6/8.11.6) id fB9IF9e02565; Sun, 9 Dec 2001 11:15:09 -0700 From: Fred Fish Message-Id: <200112091815.fB9IF9e02565@fishpond.ninemoons.com> Subject: RFA: Hopefully last one of these init_types() tweaks To: gdb-patches@sources.redhat.com Date: Sun, 09 Dec 2001 10:21:00 -0000 Cc: fnf@redhat.com Reply-To: fnf@redhat.com X-Mailer: ELM [version 2.5 PL6] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2001-12/txt/msg00251.txt.bz2 Found one more case where init_types could simply be called with the right flag bits rather than setting them after the fact. I believe this is the last one of these, except for one in java_lookup_class() that is in code that is commented out and is broken code anyway. -Fred 2001-12-09 Fred Fish * mdebugread.c (cross_ref): Pass TYPE_FLAG_STUB to init_type() rather than setting it after the type is created. Index: mdebugread.c =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/mdebugread.c,v retrieving revision 2.88 diff -c -p -r2.88 mdebugread.c *** mdebugread.c 2001/11/10 03:02:19 2.88 --- mdebugread.c 2001/12/08 21:20:59 *************** cross_ref (int fd, union aux_ext *ax, st *** 4234,4241 **** if (rf == -1) { *pname = ""; ! *tpp = init_type (type_code, 0, 0, (char *) NULL, current_objfile); ! TYPE_FLAGS (*tpp) |= TYPE_FLAG_STUB; return result; } --- 4234,4240 ---- if (rf == -1) { *pname = ""; ! *tpp = init_type (type_code, 0, TYPE_FLAG_STUB, (char *) NULL, current_objfile); return result; }