From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9700 invoked by alias); 5 Dec 2001 20:29:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9029 invoked from network); 5 Dec 2001 20:27:57 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 5 Dec 2001 20:27:57 -0000 Received: from drow by nevyn.them.org with local (Exim 3.33 #1 (Debian)) id 16Bieg-00050a-00 for ; Wed, 05 Dec 2001 15:28:34 -0500 Date: Wed, 05 Dec 2001 12:29:00 -0000 From: Daniel Jacobowitz To: gdb-patches Subject: Re: [RFA]: testsuite/gdb.base/a2-bin.exp: Consider `needs_status_wrapper' target_info Message-ID: <20011205152834.A19151@nevyn.them.org> Mail-Followup-To: gdb-patches References: <20011205202507.E29719@cygbert.vinschen.de> <20011205145440.A16409@nevyn.them.org> <20011205211708.I29719@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011205211708.I29719@cygbert.vinschen.de> User-Agent: Mutt/1.3.23i X-SW-Source: 2001-12/txt/msg00148.txt.bz2 On Wed, Dec 05, 2001 at 09:17:08PM +0100, Corinna Vinschen wrote: > On Wed, Dec 05, 2001 at 02:54:40PM -0500, Daniel Jacobowitz wrote: > > On Wed, Dec 05, 2001 at 08:25:07PM +0100, Corinna Vinschen wrote: > > > 2001-12-05 Corinna Vinschen > > > > > > * gdb.base/a2-bin.exp: Pass first test even if the return > > > code is 0 if target_info `needs_status_wrapper' exists. > > > > Please don't turn this into a PASS; it didn't really test anything as I > > read it. "unsupported" is probably the appropriate return code. > > I don't think so. The test tests that the application returns > it's usage so it has tested that the application got it's argc > correctly. That's what the test is for, right? It's just an > _additional_ test that the return code is 1. It's not GDB's > fault that the target can't return the return code correctly. [BTW, it's a2-run.exp] OK, I misread. You might want to break this up into two tests; you can just replace the one pass by two passes, and the pass you were adding by a pass and an unsupported. May not be worth the effort. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer