From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18634 invoked by alias); 29 Nov 2001 22:47:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17508 invoked from network); 29 Nov 2001 22:46:10 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by hostedprojects.ges.redhat.com with SMTP; 29 Nov 2001 22:46:10 -0000 Received: from drow by nevyn.them.org with local (Exim 3.32 #1 (Debian)) id 169Zwj-00048Z-00; Thu, 29 Nov 2001 17:46:21 -0500 Date: Tue, 20 Nov 2001 08:37:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] W.I.P. AltiVec ppc registers support. Message-ID: <20011129174621.B15429@nevyn.them.org> Mail-Followup-To: Kevin Buettner , Elena Zannoni , gdb-patches@sources.redhat.com References: <15365.39495.801289.497931@krustylu.cygnus.com> <1011129183830.ZM18856@ocotillo.lan> <15366.44991.616576.411278@krustylu.cygnus.com> <1011129222000.ZM19585@ocotillo.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1011129222000.ZM19585@ocotillo.lan> User-Agent: Mutt/1.3.23i X-SW-Source: 2001-11/txt/msg00364.txt.bz2 Message-ID: <20011120083700.TnKdUrK9D44q2EVVhXQFAzyl3SWAt1tOt8cnL6TDDCQ@z> On Thu, Nov 29, 2001 at 03:20:00PM -0700, Kevin Buettner wrote: > On Nov 29, 4:59pm, Elena Zannoni wrote: > > > > With regard to > > > > > > > Index: config/powerpc/nm-linux.h > > > [...] > > > > +#define FETCH_INFERIOR_REGISTERS > > > > > > I think this is a good thing. It *might not* be strictly necessary > > > for adding AltiVec support via PEEKUSER / POKEUSER, but it does give > > > us more control. Also doing this allows us to clean up the code in other > > > ways. E.g, the following bit from config/powerpc/nm-linux.h can be > > > removed: > > > > > > > extern int ppc_register_u_addr (int, int); > > > > #define REGISTER_U_ADDR(addr, blockend, regno) \ > > > > (addr) = ppc_register_u_addr ((blockend),(regno)); > > > > > > This in turn means that ppc_register_u_addr() can be made static > > > and that the ``ustart'' parameter can be removed. All calls to > > > register_addr() (in your new code) in ppc-linux-nat.c should be > > > changed to invoke ppc_register_u_addr() directly. > > > > > > > Unfortunately not. I thought the same, until I remembered about core > > file debugging. That function is called by fetch_core_registers() in > > core-aout.c. > > Hmm... I wonder if Linux/PPC even needs this function in core-aout.c. > Daniel J. is the expert on this stuff. Daniel, doesn't Linux/PPC use > core-regset.c instead? I'd like to kill our use of core-aout.c. Linux/PPC never used a.out cores, but unfortunately core-aout.c defines register_addr () as a wrapper for REGISTER_U_ADDR. The last time I tried to remove core-aout.c from a platform I got bitten. I think, now that we are defining FETCH_INFERIOR_REGISTERS, we can do without it - infptrace was the only big consumer I see remaining. So we might be OK without using core-aout.c at all now. My still-unsubmitted cross-core patches for PowerPC remove core-regset.o also, and very unpleasantly turn ppc-linux-nat.c into a target-dependant rather than native-dependant file, so that we can grub through the gregsets by hand. If you've got a better idea I'd love to hear it :) It will be made somewhat easier by the destruction of regmap[]. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer