From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-10863-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 32358 invoked by alias); 29 Nov 2001 22:21:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 31407 invoked from network); 29 Nov 2001 22:20:13 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by hostedprojects.ges.redhat.com with SMTP; 29 Nov 2001 22:20:13 -0000
Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA13358;
	Thu, 29 Nov 2001 14:20:11 -0800 (PST)
Received: (from kev@localhost)
	by cse.cygnus.com (8.9.3/8.9.3) id PAA19586;
	Thu, 29 Nov 2001 15:20:00 -0700
Date: Mon, 19 Nov 2001 22:53:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-ID: <1011129222000.ZM19585@ocotillo.lan>
In-Reply-To: Elena Zannoni <ezannoni@cygnus.com>
        "Re: [RFA] W.I.P. AltiVec ppc registers support." (Nov 29,  4:59pm)
References: <15365.39495.801289.497931@krustylu.cygnus.com> 
	<1011129183830.ZM18856@ocotillo.lan> 
	<15366.44991.616576.411278@krustylu.cygnus.com>
X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera)
To: Daniel Jacobowitz <drow@mvista.com>, Elena Zannoni <ezannoni@cygnus.com>
Subject: Re: [RFA] W.I.P. AltiVec ppc registers support.
Cc: gdb-patches@sources.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2001-11/txt/msg00359.txt.bz2
Message-ID: <20011119225300.cOAPNU1Gq28jGQcjxB-MmUSjM1EApNmonfBaFcCsIpY@z>

On Nov 29,  4:59pm, Elena Zannoni wrote:

>  > With regard to
>  > 
>  > > Index: config/powerpc/nm-linux.h
>  > [...]
>  > > +#define FETCH_INFERIOR_REGISTERS
>  > 
>  > I think this is a good thing.  It *might not* be strictly necessary
>  > for adding AltiVec support via PEEKUSER / POKEUSER, but it does give
>  > us more control.  Also doing this allows us to clean up the code in other
>  > ways.  E.g, the following bit from config/powerpc/nm-linux.h can be
>  > removed:
>  > 
>  > >  extern int ppc_register_u_addr (int, int);
>  > >  #define REGISTER_U_ADDR(addr, blockend, regno) \
>  > >          (addr) = ppc_register_u_addr ((blockend),(regno));
>  > 
>  > This in turn means that ppc_register_u_addr() can be made static
>  > and that the ``ustart'' parameter can be removed.  All calls to
>  > register_addr() (in your new code) in ppc-linux-nat.c should be
>  > changed to invoke ppc_register_u_addr() directly.
>  > 
> 
> Unfortunately not. I thought the same, until I remembered about core
> file debugging. That function is called by fetch_core_registers() in
> core-aout.c.

Hmm... I wonder if Linux/PPC even needs this function in core-aout.c.
Daniel J. is the expert on this stuff.  Daniel, doesn't Linux/PPC use
core-regset.c instead?

Kevin