From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30948 invoked by alias); 16 Nov 2001 20:17:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30882 invoked from network); 16 Nov 2001 20:17:28 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sourceware.cygnus.com with SMTP; 16 Nov 2001 20:17:28 -0000 Received: from reddwarf.cygnus.com (reddwarf.cygnus.com [205.180.231.12]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA28200; Fri, 16 Nov 2001 12:17:25 -0800 (PST) Received: (from msnyder@localhost) by reddwarf.cygnus.com (8.11.2/8.11.2) id fAGKF7g05478; Fri, 16 Nov 2001 12:15:07 -0800 Date: Wed, 07 Nov 2001 04:59:00 -0000 From: Michael Snyder Message-Id: <200111162015.fAGKF7g05478@reddwarf.cygnus.com> To: gdb-patches@sources.redhat.com, jimb@redhat.com Subject: symtab.c change breaks assembly lang debugging X-SW-Source: 2001-11/txt/msg00097.txt.bz2 Jim, I presume the change below was meant as an optimization, but it's based on a false assumption -- that you can't have line numbers if you don't have block symbols. That premise is untrue if you are debugging assembly language source, where the assembler emits line syms but not block syms. This change breaks the test case for assembly source debugging, gdb.asm/asm-source.exp. You would not have noticed, because that test only works on a few targets right now (d10v being one of them). Patch from Peter Schauer: * symtab.c (find_pc_sect_line): If we can't find the function containing PC, we certainly won't have line number information for that location, so return zero immediately. Michael