From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6615 invoked by alias); 16 Nov 2001 20:29:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6557 invoked from network); 16 Nov 2001 20:29:28 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sourceware.cygnus.com with SMTP; 16 Nov 2001 20:29:28 -0000 Received: from drow by nevyn.them.org with local (Exim 3.32 #1 (Debian)) id 164pcL-00049f-00; Fri, 16 Nov 2001 15:29:41 -0500 Date: Wed, 07 Nov 2001 06:24:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sources.redhat.com, jimb@redhat.com Subject: Re: symtab.c change breaks assembly lang debugging Message-ID: <20011116152941.A15960@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sources.redhat.com, jimb@redhat.com References: <200111162015.fAGKF7g05478@reddwarf.cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200111162015.fAGKF7g05478@reddwarf.cygnus.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2001-11/txt/msg00098.txt.bz2 On Fri, Nov 16, 2001 at 12:15:07PM -0800, Michael Snyder wrote: > > Jim, > > I presume the change below was meant as an optimization, but it's > based on a false assumption -- that you can't have line numbers > if you don't have block symbols. That premise is untrue if you > are debugging assembly language source, where the assembler emits > line syms but not block syms. This change breaks the test case > for assembly source debugging, gdb.asm/asm-source.exp. > > You would not have noticed, because that test only works on a few > targets right now (d10v being one of them). > > Patch from Peter Schauer: > > * symtab.c (find_pc_sect_line): If we can't find the function > containing PC, we certainly won't have line number information for > that location, so return zero immediately. OK, I should have thought of that. The problem is that this almost always indicates a lack of debugging information, and GDB historically copes very badly with not having any debugging information available. Aside from Jim's address range cleanups, which are certainly a good solution for the cases they can handle, I don't know what to do about this. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer